You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/04/26 22:00:16 UTC
Review Request: FLUME-1156:If config file has empty sources, then throws NPE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4897/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Fixed by checking for null or empty string before splitting it.
This addresses bug Flume-1156.
https://issues.apache.org/jira/browse/Flume-1156
Diffs
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 695ad60
Diff: https://reviews.apache.org/r/4897/diff
Testing
-------
Ran an agent with null source string. Looks ok
Thanks,
Hari
Re: Review Request: FLUME-1156:If config file has empty sources,
then throws NPE
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4897/#review7307
-----------------------------------------------------------
Ship it!
+1
lgtm
- Prasad
On 2012-04-26 20:00:16, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4897/
> -----------------------------------------------------------
>
> (Updated 2012-04-26 20:00:16)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Fixed by checking for null or empty string before splitting it.
>
>
> This addresses bug Flume-1156.
> https://issues.apache.org/jira/browse/Flume-1156
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 695ad60
>
> Diff: https://reviews.apache.org/r/4897/diff
>
>
> Testing
> -------
>
> Ran an agent with null source string. Looks ok
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: FLUME-1156:If config file has empty sources,
then throws NPE
Posted by Will McQueen <wi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4897/#review7287
-----------------------------------------------------------
Ship it!
lgtm! Ran test against the patch, I don't see the NPE any longer. Thanks!
- Will
On 2012-04-26 20:00:16, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4897/
> -----------------------------------------------------------
>
> (Updated 2012-04-26 20:00:16)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Fixed by checking for null or empty string before splitting it.
>
>
> This addresses bug Flume-1156.
> https://issues.apache.org/jira/browse/Flume-1156
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 695ad60
>
> Diff: https://reviews.apache.org/r/4897/diff
>
>
> Testing
> -------
>
> Ran an agent with null source string. Looks ok
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: FLUME-1156:If config file has empty sources,
then throws NPE
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4897/#review7308
-----------------------------------------------------------
Ship it!
+1
Will commit if tests pass.
- Arvind
On 2012-04-26 20:00:16, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4897/
> -----------------------------------------------------------
>
> (Updated 2012-04-26 20:00:16)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Fixed by checking for null or empty string before splitting it.
>
>
> This addresses bug Flume-1156.
> https://issues.apache.org/jira/browse/Flume-1156
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 695ad60
>
> Diff: https://reviews.apache.org/r/4897/diff
>
>
> Testing
> -------
>
> Ran an agent with null source string. Looks ok
>
>
> Thanks,
>
> Hari
>
>