You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@iceberg.apache.org by GitBox <gi...@apache.org> on 2018/12/06 21:56:25 UTC

[GitHub] mccheah commented on a change in pull request #28: Apply baseline checkstyle for iceberg-api only

mccheah commented on a change in pull request #28: Apply baseline checkstyle for iceberg-api only
URL: https://github.com/apache/incubator-iceberg/pull/28#discussion_r239629775
 
 

 ##########
 File path: .baseline/idea/intellij-java-palantir-style.xml
 ##########
 @@ -0,0 +1,461 @@
+<project version="4">
 
 Review comment:
   @iamdanfox would it be reasonable to allow the name of this file to be configurable? I was looking at the Baseline source code and the file name is [hardcoded to this path](https://github.com/palantir/gradle-baseline/blob/9c95a967943b375f7da719b3265d2796c4a8c72f/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineIdea.groovy#L65). But including a reference to `Palantir` seems strange for projects that want to use baseline that don't find their origins with Palantir itself.
   
   What I'd like to do instead is to run `./gradlew baselineUpdateConfig` to get this template, but then be able to rename this file and reference the renamed path in `build.gradle`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services