[GitHub] [hudi] codope commented on a diff in pull request #8233: [HUDI-5956] Simple repair spark sql dag ui display problem

["codope (via GitHub)" <gi...@apache.org>]

codope commented on code in PR #8233:
URL: https://github.com/apache/hudi/pull/8233#discussion_r1298071684


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -123,6 +126,24 @@ object HoodieSparkSqlWriter {
             streamingWritesParamsOpt: Option[StreamingWriteParams] = Option.empty,
             hoodieWriteClient: Option[SparkRDDWriteClient[_]] = Option.empty):
   (Boolean, HOption[String], HOption[String], HOption[String], SparkRDDWriteClient[_], HoodieTableConfig) = {
+    //TODO reuse DataWritingCommand sparkPlan, reduce the number of sql list in SPARK UI SQL tag, rendering raw DAG

Review Comment:
   Will it incure some overhead if we don't reuse? Why not complete the TODO in this PR itself?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org