You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Andy Grove (JIRA)" <tu...@ws.apache.org> on 2007/04/23 16:19:15 UTC

[jira] Created: (TUSCANY-1222) Incorrect assertions in XSDChoiceTest

Incorrect assertions in XSDChoiceTest
-------------------------------------

                 Key: TUSCANY-1222
                 URL: https://issues.apache.org/jira/browse/TUSCANY-1222
             Project: Tuscany
          Issue Type: Bug
          Components: Java SDO Community Test Suite
            Reporter: Andy Grove


Two of the tests in XSDChoiceTest were incorrectly asserting that the types were created with sequenced=false. After re-reading the specification, it is clear that these particular types should have sequenced=true because the choice definitions have maxOccurs > 1. 

I am attaching a patch that resolves this issue and also promotes XSDChoiceTest to the AdoptedTestSuite. There is now a single test failure when running against Tuscany and this is due to a bug in Tuscany (see JIRA-1221).

Thanks,

Andy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-1222) Incorrect assertions in XSDChoiceTest

Posted by "Andy Grove (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Grove updated TUSCANY-1222:
--------------------------------

    Attachment: jira-1222.patch

> Incorrect assertions in XSDChoiceTest
> -------------------------------------
>
>                 Key: TUSCANY-1222
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1222
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SDO Community Test Suite
>            Reporter: Andy Grove
>         Attachments: jira-1222.patch
>
>
> Two of the tests in XSDChoiceTest were incorrectly asserting that the types were created with sequenced=false. After re-reading the specification, it is clear that these particular types should have sequenced=true because the choice definitions have maxOccurs > 1. 
> I am attaching a patch that resolves this issue and also promotes XSDChoiceTest to the AdoptedTestSuite. There is now a single test failure when running against Tuscany and this is due to a bug in Tuscany (see JIRA-1221).
> Thanks,
> Andy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Resolved: (TUSCANY-1222) Incorrect assertions in XSDChoiceTest

Posted by "Frank Budinsky (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Budinsky resolved TUSCANY-1222.
-------------------------------------

    Resolution: Fixed

Committed revision 531507.

> Incorrect assertions in XSDChoiceTest
> -------------------------------------
>
>                 Key: TUSCANY-1222
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1222
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SDO Community Test Suite
>            Reporter: Andy Grove
>         Attachments: jira-1222-v2.patch, jira-1222.patch
>
>
> Two of the tests in XSDChoiceTest were incorrectly asserting that the types were created with sequenced=false. After re-reading the specification, it is clear that these particular types should have sequenced=true because the choice definitions have maxOccurs > 1. 
> I am attaching a patch that resolves this issue and also promotes XSDChoiceTest to the AdoptedTestSuite. There is now a single test failure when running against Tuscany and this is due to a bug in Tuscany (see JIRA-1221).
> Thanks,
> Andy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-1222) Incorrect assertions in XSDChoiceTest

Posted by "Andy Grove (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Grove updated TUSCANY-1222:
--------------------------------

    Attachment: jira-1222-v2.patch

Attaching a new version of the patch file. Please disregard the previous one.

This new patch fixes a further error in the test. After applying this patch, Tuscany passes all tests in XSDChoiceTest.

JIRA-1221 has been closed as invalid.

> Incorrect assertions in XSDChoiceTest
> -------------------------------------
>
>                 Key: TUSCANY-1222
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1222
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SDO Community Test Suite
>            Reporter: Andy Grove
>         Attachments: jira-1222-v2.patch, jira-1222.patch
>
>
> Two of the tests in XSDChoiceTest were incorrectly asserting that the types were created with sequenced=false. After re-reading the specification, it is clear that these particular types should have sequenced=true because the choice definitions have maxOccurs > 1. 
> I am attaching a patch that resolves this issue and also promotes XSDChoiceTest to the AdoptedTestSuite. There is now a single test failure when running against Tuscany and this is due to a bug in Tuscany (see JIRA-1221).
> Thanks,
> Andy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org