You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Dan Dumont (Created) (JIRA)" <ji...@apache.org> on 2011/12/01 20:04:41 UTC
[jira] [Created] (SHINDIG-1664) Actions, selection, and open-views
feature issues in a locked domain environment.
Actions, selection, and open-views feature issues in a locked domain environment.
---------------------------------------------------------------------------------
Key: SHINDIG-1664
URL: https://issues.apache.org/jira/browse/SHINDIG-1664
Project: Shindig
Issue Type: Bug
Components: Javascript
Environment: Shindig with locked domains enabled.
Reporter: Dan Dumont
Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1664) Actions, selection, and open-views
feature issues in a locked domain environment.
Posted by "Dan Dumont (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont resolved SHINDIG-1664.
---------------------------------
Resolution: Fixed
r1211090
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
> Attachments: upstream.patch
>
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162969#comment-13162969 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3630
-----------------------------------------------------------
LGTM, I went through selection and actions briefly and focus on the open-views.
Thanks,
Jason
- Jason
On 2011-12-05 14:19:41, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-05 14:19:41)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162799#comment-13162799 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
bq. On 2011-12-04 18:55:14, Ryan Baxter wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, line 262
bq. > <https://reviews.apache.org/r/2994/diff/4/?file=61735#file61735line262>
bq. >
bq. > Rename this method if we are calling it for URL sites as well
I want to wait to do that in another changeset with the changes to align the two site types under a common parent class.
bq. On 2011-12-04 18:55:14, Ryan Baxter wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, line 610
bq. > <https://reviews.apache.org/r/2994/diff/4/?file=61735#file61735line610>
bq. >
bq. > So can I now call this for URL sites as well? If so we should rename the method
No, there's another method for url sites with a different name.
bq. On 2011-12-04 18:55:14, Ryan Baxter wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, line 622
bq. > <https://reviews.apache.org/r/2994/diff/4/?file=61735#file61735line622>
bq. >
bq. > Rename this method because it is no longer for just GadgetSites.
Yeah, since this method is new, I'm fine with that.
bq. On 2011-12-04 18:55:14, Ryan Baxter wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, line 912
bq. > <https://reviews.apache.org/r/2994/diff/4/?file=61735#file61735line912>
bq. >
bq. > Are we sure there are no other assumptions about the sites_ array containing only GadgetSites?
It looks like everything is accounted for now. Most calls just iterate over the map looking for a site with an id or iframeId of a particular value.
The refresh tokens call has been scoped to only operate on gadget sites.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3609
-----------------------------------------------------------
On 2011-12-02 20:40:53, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-02 20:40:53)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161828#comment-13161828 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/
-----------------------------------------------------------
(Updated 2011-12-02 20:07:19.352361)
Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
Summary
-------
As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
Side note:
The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
This addresses bug SHINDIG-1664.
https://issues.apache.org/jira/browse/SHINDIG-1664
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
Diff: https://reviews.apache.org/r/2994/diff
Testing
-------
Updated jsunit tests, they all pass.
Tested with some gadgets to exercise the open-views, selection, and actions api.
Thanks,
Dan
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161817#comment-13161817 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/
-----------------------------------------------------------
(Updated 2011-12-02 19:50:07.319085)
Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
Changes
-------
Originally uploaded an earlier version of my patch. This one should be current.
Summary
-------
As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
Side note:
The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
This addresses bug SHINDIG-1664.
https://issues.apache.org/jira/browse/SHINDIG-1664
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
Diff: https://reviews.apache.org/r/2994/diff
Testing
-------
Updated jsunit tests, they all pass.
Tested with some gadgets to exercise the open-views, selection, and actions api.
Thanks,
Dan
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163716#comment-13163716 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/
-----------------------------------------------------------
(Updated 2011-12-06 17:54:35.648638)
Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
Changes
-------
Updated patch to address the issue Ryan pointed out.
Summary
-------
As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
Side note:
The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
This addresses bug SHINDIG-1664.
https://issues.apache.org/jira/browse/SHINDIG-1664
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
Diff: https://reviews.apache.org/r/2994/diff
Testing
-------
Updated jsunit tests, they all pass.
Tested with some gadgets to exercise the open-views, selection, and actions api.
Thanks,
Dan
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
> Attachments: upstream.patch
>
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163723#comment-13163723 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
bq. On 2011-12-04 18:55:14, Ryan Baxter wrote:
bq. > You might want to test all your feature xml uses changes work when RPC arbitration is enabled as well.
Turned that on and I don't see any issues running through the test gadgets.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3609
-----------------------------------------------------------
On 2011-12-06 17:54:35, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-06 17:54:35)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
> Attachments: upstream.patch
>
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163608#comment-13163608 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
bq. On 2011-12-06 02:54:06, Ryan Baxter wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, line 610
bq. > <https://reviews.apache.org/r/2994/diff/5/?file=61879#file61879line610>
bq. >
bq. > This line seems to be returning undefined for me. I didn't have time to look into it too much. We can take a look at it tomorrow :)
Thanks for catching that! The scope is being lost because it's calling the method instead of the site-dot-method. I'll update the patch to make sure the scope is maintained in the call.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3654
-----------------------------------------------------------
On 2011-12-05 14:19:41, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-05 14:19:41)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163811#comment-13163811 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3671
-----------------------------------------------------------
Ship it!
Committed r1211090
- Dan
On 2011-12-06 20:21:36, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-06 20:21:36)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
> Attachments: upstream.patch
>
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162801#comment-13162801 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/
-----------------------------------------------------------
(Updated 2011-12-05 14:19:41.081436)
Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
Changes
-------
Updated to address feedback.
Summary
-------
As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
Side note:
The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
This addresses bug SHINDIG-1664.
https://issues.apache.org/jira/browse/SHINDIG-1664
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
Diff: https://reviews.apache.org/r/2994/diff
Testing
-------
Updated jsunit tests, they all pass.
Tested with some gadgets to exercise the open-views, selection, and actions api.
Thanks,
Dan
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161842#comment-13161842 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/
-----------------------------------------------------------
(Updated 2011-12-02 20:40:53.465844)
Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
Changes
-------
I found some good test gadgets in the samplecontainer.
Found a few type-o's with them. Had to update the voip one because selection is an array of objects according to the spec and my changes fix the bug that was in shindig.
Summary
-------
As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
Side note:
The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
This addresses bug SHINDIG-1664.
https://issues.apache.org/jira/browse/SHINDIG-1664
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
Diff: https://reviews.apache.org/r/2994/diff
Testing
-------
Updated jsunit tests, they all pass.
Tested with some gadgets to exercise the open-views, selection, and actions api.
Thanks,
Dan
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1664) Actions, selection, and open-views
feature issues in a locked domain environment.
Posted by "Dan Dumont (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1664:
--------------------------------
Attachment: upstream.patch
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
> Attachments: upstream.patch
>
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161859#comment-13161859 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3603
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/2994/#comment8033>
Instead of doing site.holder_ you can use site.getActiveUrlHolder(). Here's what I've done before in this case:
var fGetHolder = site.getActiveGadgetHolder || site.getActiveUrlHolder;
var holder = fGetHolder.call(site);
- Stanton
On 2011-12-02 20:40:53, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-02 20:40:53)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163799#comment-13163799 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/
-----------------------------------------------------------
(Updated 2011-12-06 20:21:36.585266)
Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
Changes
-------
Apparently, rpc callbacks should only take 1 parameter. In the case where these take more than one, I updated the code to pass them as an array and apply them on the original callback.
Summary
-------
As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
Side note:
The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
This addresses bug SHINDIG-1664.
https://issues.apache.org/jira/browse/SHINDIG-1664
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
Diff: https://reviews.apache.org/r/2994/diff
Testing
-------
Updated jsunit tests, they all pass.
Tested with some gadgets to exercise the open-views, selection, and actions api.
Thanks,
Dan
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
> Attachments: upstream.patch
>
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161949#comment-13161949 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
bq. On 2011-12-02 21:17:46, Stanton Sievers wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, line 845
bq. > <https://reviews.apache.org/r/2994/diff/4/?file=61735#file61735line845>
bq. >
bq. > Instead of doing site.holder_ you can use site.getActiveUrlHolder(). Here's what I've done before in this case:
bq. >
bq. > var fGetHolder = site.getActiveGadgetHolder || site.getActiveUrlHolder;
bq. > var holder = fGetHolder.call(site);
Must have missed that method, didn't notice it.
I'll update the patch on monday.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3603
-----------------------------------------------------------
On 2011-12-02 20:40:53, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-02 20:40:53)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162439#comment-13162439 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3609
-----------------------------------------------------------
You might want to test all your feature xml uses changes work when RPC arbitration is enabled as well.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml
<https://reviews.apache.org/r/2994/#comment8039>
Small nit can we make the spacing consistent here?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js
<https://reviews.apache.org/r/2994/#comment8043>
This variable name does name make sense in this case URL sites do not contain gadgets.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/2994/#comment8046>
Rename this method if we are calling it for URL sites as well
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/2994/#comment8044>
So can I now call this for URL sites as well? If so we should rename the method
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/2994/#comment8045>
Rename this method because it is no longer for just GadgetSites.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/2994/#comment8042>
Are we sure there are no other assumptions about the sites_ array containing only GadgetSites?
- Ryan
On 2011-12-02 20:40:53, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-02 20:40:53)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162979#comment-13162979 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3631
-----------------------------------------------------------
Thanks everyone for the reviews. I'd like an additional review from someone not on my team though :)
Please reply if you think you can provide one and I can wait to hear back from you, otherwise I'll commit this change tomorrow.
- Dan
On 2011-12-05 14:19:41, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-05 14:19:41)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1664) Actions, selection, and open-views
feature issues in a locked domain environment.
Posted by "Dan Dumont (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1664:
--------------------------------
Attachment: (was: upstream.patch)
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
> Attachments: upstream.patch
>
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163777#comment-13163777 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3668
-----------------------------------------------------------
Ship it!
Looks good to me.
- Matthew
On 2011-12-06 17:54:35, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-06 17:54:35)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
> Attachments: upstream.patch
>
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163294#comment-13163294 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3654
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/2994/#comment8155>
This line seems to be returning undefined for me. I didn't have time to look into it too much. We can take a look at it tomorrow :)
- Ryan
On 2011-12-05 14:19:41, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-05 14:19:41)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
bq. The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1664) Actions, selection, and
open-views feature issues in a locked domain environment.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161809#comment-13161809 ]
jiraposter@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/
-----------------------------------------------------------
Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton Sievers.
Summary
-------
As a general rule, any time anyone is writing a feature using RPC, those endpoints should never expect to get a function (or something that contains a function) as an argument.
The serialization that happens when running with locked domains will null the function argument when (and only when) in locked domains (so jsunit tests will pass).
The check is a bit to expensive to perform for each rpc call so I think people are just going to have to stay sharp.
Side note:
The ugly code you'll run into to get the gadget holder from a site is temporary. I want to go in later and refactor gadget sites, gadget holders, url sites, and url holders to inherit from a common parent an remove a bunch of the duplication and make the methods make more sense.
This addresses bug SHINDIG-1664.
https://issues.apache.org/jira/browse/SHINDIG-1664
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1209641
Diff: https://reviews.apache.org/r/2994/diff
Testing
-------
Updated jsunit tests, they all pass.
Tested with some gadgets to exercise the open-views, selection, and actions api.
Thanks,
Dan
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1664) Actions, selection, and open-views
feature issues in a locked domain environment.
Posted by "Dan Dumont (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1664:
--------------------------------
Attachment: upstream.patch
> Actions, selection, and open-views feature issues in a locked domain environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
> Attachments: upstream.patch
>
>
> Inspection of the code reveals that functions were being passed as arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira