You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/12/20 01:37:04 UTC
[GitHub] reddycharan commented on a change in pull request #892: Misc LedgerHandle changes
reddycharan commented on a change in pull request #892: Misc LedgerHandle changes
URL: https://github.com/apache/bookkeeper/pull/892#discussion_r157919917
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -204,7 +204,7 @@ public void safeRun() {
}
protected void initializeExplicitLacFlushPolicy() {
- if (!metadata.isClosed() && bk.getExplicitLacInterval() > 0) {
+ if (!metadata.isClosed() && !(this instanceof ReadOnlyLedgerHandle) && bk.getExplicitLacInterval() > 0) {
Review comment:
yep, I missed this fix. Caught this while porting changes from community to our codebase, but forgot to push it back to the community.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services