svn commit: r1459473 - /hbase/branches/0.89-fb/src/main/resources/hbase-webapps/master/master.jsp

[li...@apache.org]

Author: liyin
Date: Thu Mar 21 18:54:05 2013
New Revision: 1459473

URL: http://svn.apache.org/r1459473
Log:
[HBASE-8111] Avoids un necessary DNS lookup for master web ui page

Author: rshroff

Summary:
Currently, whenever you load the master web ui, it will fetch the
hostname by giving the address to generate the RS url. This is a DNS
lookup, which might be slow sometimes. Hence, when we have a lot of RS like
SH003(349), these DNS timeouts cause the loading of the web ui to fail.

This failure will lead to alarm when the cluster goes into production.

The fix is to use already cached hostName to avoid the DNS lookup.

Test Plan:
tested it on SH003
http://hbaseproxy001.prn1.facebook.com/hbase_master/searchhbase003-frc1/master.jsp

Reviewers: liyintang, aleksandr

Reviewed By: aleksandr

CC: arjen, aleksandr, hbase-eng@

Differential Revision: https://phabricator.fb.com/D739051

Task ID: 2185822

Modified:
    hbase/branches/0.89-fb/src/main/resources/hbase-webapps/master/master.jsp

Modified: hbase/branches/0.89-fb/src/main/resources/hbase-webapps/master/master.jsp
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/resources/hbase-webapps/master/master.jsp?rev=1459473&r1=1459472&r2=1459473&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/resources/hbase-webapps/master/master.jsp (original)
+++ hbase/branches/0.89-fb/src/main/resources/hbase-webapps/master/master.jsp Thu Mar 21 18:54:05 2013
@@ -150,7 +150,7 @@
      Arrays.sort(serverNames);
      for (String serverName: serverNames) {
        HServerInfo hsi = serverToServerInfos.get(serverName);
-       String hostname = hsi.getServerAddress().getHostname() + ":" + rsInfoPort;
+       String hostname = hsi.getHostname() + ":" + rsInfoPort;
        String url = "http://" + hostname + "/";
        totalRegions += hsi.getLoad().getNumberOfRegions();
        totalRequests += hsi.getLoad().getNumberOfRequests() / interval;