You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "chandrasekhar-188k (via GitHub)" <gi...@apache.org> on 2026/07/18 10:34:39 UTC
[PR] Make Metadata Timestamp Clock Skew Configurable [iceberg]
chandrasekhar-188k opened a new pull request, #17286:
URL: https://github.com/apache/iceberg/pull/17286
Make Metadata Timestamp Clock Skew Configurable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Make Metadata Timestamp Clock Skew Configurable [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #17286: Core: Make Metadata Timestamp Clock Skew Configurable
URL: https://github.com/apache/iceberg/pull/17286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Make Metadata Timestamp Clock Skew Configurable [iceberg]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #17286:
URL: https://github.com/apache/iceberg/pull/17286#discussion_r3608830956
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -66,6 +66,16 @@ public class TableMetadata implements Serializable {
private static final long ONE_MINUTE = TimeUnit.MINUTES.toMillis(1);
+ /**
+ * System property that controls the allowed clock-skew tolerance (in milliseconds) used when
+ * validating that snapshot-log and metadata-log entries are monotonically increasing in time.
+ * Defaults to 1 minute if unset or invalid.
+ */
+ static final String CLOCK_SKEW_TOLERANCE_MS_PROPERTY =
+ "iceberg.table-metadata.clock-skew-tolerance-ms";
+
+ private static final long DEFAULT_CLOCK_SKEW_TOLERANCE_MS = ONE_MINUTE;
Review Comment:
whats the motivation for doing this ?
heads up in v4 we need to have monotonic timestamps
cc @stevenzwu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Make Metadata Timestamp Clock Skew Configurable [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17286:
URL: https://github.com/apache/iceberg/pull/17286#issuecomment-5418762195
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Make Metadata Timestamp Clock Skew Configurable [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17286:
URL: https://github.com/apache/iceberg/pull/17286#issuecomment-5502480671
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Make Metadata Timestamp Clock Skew Configurable [iceberg]
Posted by "chandrasekhar-188k (via GitHub)" <gi...@apache.org>.
chandrasekhar-188k commented on code in PR #17286:
URL: https://github.com/apache/iceberg/pull/17286#discussion_r3609686912
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -66,6 +66,16 @@ public class TableMetadata implements Serializable {
private static final long ONE_MINUTE = TimeUnit.MINUTES.toMillis(1);
+ /**
+ * System property that controls the allowed clock-skew tolerance (in milliseconds) used when
+ * validating that snapshot-log and metadata-log entries are monotonically increasing in time.
+ * Defaults to 1 minute if unset or invalid.
+ */
+ static final String CLOCK_SKEW_TOLERANCE_MS_PROPERTY =
+ "iceberg.table-metadata.clock-skew-tolerance-ms";
+
+ private static final long DEFAULT_CLOCK_SKEW_TOLERANCE_MS = ONE_MINUTE;
Review Comment:
in deployments where multiple compute engines (for example, Spark, Flink, Trino, or custom applications) operate on the same Iceberg table from different clusters, temporary clock skew greater than one minute can occur despite otherwise healthy deployments. In such cases, valid commits may fail because the metadata timestamp appears to be too far in the future relative to the committing process. we have observed this issue in some of our deployments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org