You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Kenneth Howe (JIRA)" <ji...@apache.org> on 2018/02/23 00:04:14 UTC
[jira] [Comment Edited] (GEODE-3584) Refactor ServerLauncher and
LocatorLauncher to eliminate code duplication
[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373286#comment-16373286 ]
Kenneth Howe edited comment on GEODE-3584 at 2/23/18 12:04 AM:
---------------------------------------------------------------
I did some work resolving compilation conflicts between Cyrille's patch and the Geode develop branch as of Jan17, 2018. Pushed to Geode repo on branch feature/GEODE-3584
was (Author: khowe):
I done some work resolving compilation coflicts between Cyrille's patch and the Geode develop branch as of Jan17, 2018. Pushed to Geode repo on branch feature/GEODE-3584
> Refactor ServerLauncher and LocatorLauncher to eliminate code duplication
> -------------------------------------------------------------------------
>
> Key: GEODE-3584
> URL: https://issues.apache.org/jira/browse/GEODE-3584
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Affects Versions: 1.2.0
> Reporter: Kenneth Howe
> Priority: Major
> Attachments: GEODE-3584-1, GEODE-3584-WIP, GEODE-3584-WIP-2, GEODE-3584-WIP-3, GEODE-3584-WIP-4
>
>
> There is some duplication of code in the Launcher classes that can be eliminated. Both classes have methods such as getBindAddress (called getServerBindAddress in ServerLauncher) that could be hoisted into AbstractLauncher class that they both extend. The same goes for the inner State classes of the Launchers; they have methods that could be moved to AbstractLauncher.ServiceState.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)