You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/02 02:26:06 UTC
[GitHub] [ozone] umamaheswararao commented on a diff in pull request #3458: HDDS-6764: EC: DN ability to create RECOVERING containers for EC reconstruction.
umamaheswararao commented on code in PR #3458:
URL: https://github.com/apache/ozone/pull/3458#discussion_r887443183
##########
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/container/ContainerTestHelper.java:
##########
@@ -436,6 +441,7 @@ public static Builder newPutBlockRequestBuilder(Pipeline pipeline,
ContainerProtos.PutBlockRequestProto.Builder putRequest =
ContainerProtos.PutBlockRequestProto.newBuilder();
+ putRequest.setEof(true);
Review Comment:
Ah, I think I added when debugging.
##########
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto:
##########
@@ -270,6 +271,8 @@ message CreateContainerRequestProto {
repeated KeyValue metadata = 2;
optional ContainerType containerType = 3 [default = KeyValueContainer];
optional int32 replicaIndex = 4;
+ //optional LifeCycleState state = 5;
Review Comment:
Below we have added state. I can remove this. Thanks for pointing.
##########
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto:
##########
@@ -270,6 +271,8 @@ message CreateContainerRequestProto {
repeated KeyValue metadata = 2;
optional ContainerType containerType = 3 [default = KeyValueContainer];
optional int32 replicaIndex = 4;
+ //optional LifeCycleState state = 5;
Review Comment:
removed it. Below state is there.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -471,7 +473,9 @@ public void validateContainerCommand(
}
State containerState = container.getContainerState();
- if (!HddsUtils.isReadOnly(msg) && containerState != State.OPEN) {
+ if (!HddsUtils.isReadOnly(msg)
+ && (containerState != State.OPEN
+ && containerState != State.RECOVERING)) {
Review Comment:
I tried to export into a method. Let's see if that's make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org