You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/01/19 06:49:06 UTC
[GitHub] [incubator-brpc] Suse130224 opened a new pull request #1028:
support unix socket
Suse130224 opened a new pull request #1028: support unix socket
URL: https://github.com/apache/incubator-brpc/pull/1028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on issue #1028: support unix
socket
Posted by GitBox <gi...@apache.org>.
jamesge commented on issue #1028: support unix socket
URL: https://github.com/apache/incubator-brpc/pull/1028#issuecomment-575974717
Thanks for your contribution. However, the support for unix sockets are better encapsulated in EndPoint without changing too much other code, especially the Channel. Another limit is that EndPoints are widely used and adding a char array inside it is unacceptable. Since valid port is between [0, 65535], it's possible that we put a pointer inside EndPoint without changing the structure size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Suse130224 closed pull request #1028: support unix
socket
Posted by GitBox <gi...@apache.org>.
Suse130224 closed pull request #1028: support unix socket
URL: https://github.com/apache/incubator-brpc/pull/1028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org