You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2019/03/15 13:58:49 UTC
[GitHub] [knox] rlevas opened a new pull request #74: KNOX-1111 - 2-way SSL
Truststore and Keystore Improvements
rlevas opened a new pull request #74: KNOX-1111 - 2-way SSL Truststore and Keystore Improvements
URL: https://github.com/apache/knox/pull/74
## What changes were proposed in this pull request?
Most of the improvements needed for [KNOX-1111](https://issues.apache.org/jira/browse/KNOX-1111) have been completed using various Jiras. However, the ability to set a custom trust store when two-way SSL was not enabled for a service was not implemented. This patch implements that feature.
## How was this patch tested?
Added and ran unit test:
```
mvn -T.5C verify -Prelease,package
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:59 min (Wall Clock)
[INFO] Finished at: 2019-03-14T20:56:51-04:00
[INFO] Final Memory: 292M/1907M
[INFO] ------------------------------------------------------------------------
```
Manually tested various scenarios:
- two-way SSL **with no** trust store configured, used the configured identity keystore instead
- two-way SSL **with** a trust store configured, used the configured trust store
- one-way SSL **with no** trust store configured, no custom SSL context was created (assume cacerts was used)
- one-way SSL **with** a trust store configured, used the configured trust store
Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services