You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "pvary (via GitHub)" <gi...@apache.org> on 2025/08/20 05:24:38 UTC
[PR] Testing the effect of the removal of the position delete with row data feature [iceberg]
pvary opened a new pull request, #13870:
URL: https://github.com/apache/iceberg/pull/13870
Let's see what tests we have in place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Testing the effect of the removal of the position delete with row data feature [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13870:
URL: https://github.com/apache/iceberg/pull/13870#issuecomment-3331143321
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Testing the effect of the removal of the position delete with row data feature [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #13870: Testing the effect of the removal of the position delete with row data feature
URL: https://github.com/apache/iceberg/pull/13870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Testing the effect of the removal of the position delete with row data feature [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #13870:
URL: https://github.com/apache/iceberg/pull/13870#discussion_r2294439735
##########
data/src/test/java/org/apache/iceberg/io/TestWriterMetrics.java:
##########
@@ -152,9 +152,8 @@ public void testPositionDeleteMetrics() throws IOException {
writerFactory.newPositionDeleteWriter(outputFile, table.spec(), null);
try {
- T deletedRow = toRow(3, "3", true, 3L);
PositionDelete<T> positionDelete = PositionDelete.create();
- positionDelete.set("File A", 1, deletedRow);
+ positionDelete.set("File A", 1);
Review Comment:
The deprecation is this override of the `set` method, right? Anything else we would deprecate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Testing the effect of the removal of the position delete with row data feature [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on code in PR #13870:
URL: https://github.com/apache/iceberg/pull/13870#discussion_r2297560279
##########
data/src/test/java/org/apache/iceberg/io/TestWriterMetrics.java:
##########
@@ -152,9 +152,8 @@ public void testPositionDeleteMetrics() throws IOException {
writerFactory.newPositionDeleteWriter(outputFile, table.spec(), null);
try {
- T deletedRow = toRow(3, "3", true, 3L);
PositionDelete<T> positionDelete = PositionDelete.create();
- positionDelete.set("File A", 1, deletedRow);
+ positionDelete.set("File A", 1);
Review Comment:
This method is already there.
We can formally deprecate only two methods in the `PositionDelete`. We need to keep the row schema in the other places as they are used by the equality deletes.
The interesting thing is `PositionDeletesTable` which will not contain the row after this. We can keep the column, but it will be always empty, but that seems right. This is the same for every V3 tables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Testing the effect of the removal of the position delete with row data feature [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13870:
URL: https://github.com/apache/iceberg/pull/13870#issuecomment-3363687755
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org