You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "yuxian0908 (via GitHub)" <gi...@apache.org> on 2025/05/20 02:47:59 UTC
[PR] KAFKA-19313: Replace LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by UnifiedLog.UNKNOWN_OFFSET [kafka]
yuxian0908 opened a new pull request, #19767:
URL: https://github.com/apache/kafka/pull/19767
Replaces the UNIFIED_LOG_UNKNOWN_OFFSET constant in LogOffsetMetadata with UnifiedLog.UNKNOWN_OFFSET.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19313: Replace LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by UnifiedLog.UNKNOWN_OFFSET [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19767:
URL: https://github.com/apache/kafka/pull/19767#discussion_r2104845326
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetMetadata.java:
##########
@@ -27,17 +27,16 @@
public final class LogOffsetMetadata {
//TODO KAFKA-14484 remove once UnifiedLog has been moved to the storage module
Review Comment:
This comment is invalid now, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19313: Replace LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by UnifiedLog.UNKNOWN_OFFSET [kafka]
Posted by "yuxian0908 (via GitHub)" <gi...@apache.org>.
yuxian0908 commented on code in PR #19767:
URL: https://github.com/apache/kafka/pull/19767#discussion_r2105670470
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetMetadata.java:
##########
@@ -27,17 +27,16 @@
public final class LogOffsetMetadata {
//TODO KAFKA-14484 remove once UnifiedLog has been moved to the storage module
Review Comment:
Yes! I believe you're right — that comment is outdated now. Thanks for the review! I've cleaned it up accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19313: Replace LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by UnifiedLog.UNKNOWN_OFFSET [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #19767:
URL: https://github.com/apache/kafka/pull/19767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org