You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/06/21 12:32:41 UTC
[GitHub] [rocketmq] yglovewms opened a new pull request #3024: add:对于sample部分，统一设置namesrv的地址为127.0.0.1，并用常量StartConstants.DEFAULT_NA…
yglovewms opened a new pull request #3024:
URL: https://github.com/apache/rocketmq/pull/3024
…MESRV_ADDRESS存储方便统一修改，统一了之前部分sample使用： producer.setNamesrvAddr("127.0.0.1:9876")不方便修改的情况，并且对于没有设置namesrv的sample设置了地址，避免了connect to null错误，使得sample可以直接在idea本地运行;
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3024: add:对于sample部分，统一设置namesrv的地址为127.0.0.1，并用常量StartConstants.DEFAULT_NA…
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3024:
URL: https://github.com/apache/rocketmq/pull/3024#issuecomment-865003123
[](https://coveralls.io/builds/40744542)
Coverage increased (+0.07%) to 54.129% when pulling **69522c89f9b238d5da1768676e1696d9e8f865a2 on yglovewms:master** into **df1d93fc8859377b92ba87c6947911281656f355 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3024: add:对于sample部分，统一设置namesrv的地址为127.0.0.1，并用常量StartConstants.DEFAULT_NA…
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3024:
URL: https://github.com/apache/rocketmq/pull/3024#issuecomment-865003123
[](https://coveralls.io/builds/40744542)
Coverage increased (+0.07%) to 54.129% when pulling **69522c89f9b238d5da1768676e1696d9e8f865a2 on yglovewms:master** into **df1d93fc8859377b92ba87c6947911281656f355 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yglovewms closed pull request #3024: add:对于sample部分，统一设置namesrv的地址为127.0.0.1，并用常量StartConstants.DEFAULT_NA…
Posted by GitBox <gi...@apache.org>.
yglovewms closed pull request #3024:
URL: https://github.com/apache/rocketmq/pull/3024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yglovewms closed pull request #3024: add:对于sample部分，统一设置namesrv的地址为127.0.0.1，并用常量StartConstants.DEFAULT_NA…
Posted by GitBox <gi...@apache.org>.
yglovewms closed pull request #3024:
URL: https://github.com/apache/rocketmq/pull/3024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3024: add:对于sample部分，统一设置namesrv的地址为127.0.0.1，并用常量StartConstants.DEFAULT_NA…
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3024:
URL: https://github.com/apache/rocketmq/pull/3024#issuecomment-865003123
[](https://coveralls.io/builds/40742938)
Coverage increased (+0.1%) to 54.152% when pulling **f2fc96987516c0cf39b34c4f15079476a0fa8d79 on yglovewms:master** into **df1d93fc8859377b92ba87c6947911281656f355 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3024: add:对于sample部分，统一设置namesrv的地址为127.0.0.1，并用常量StartConstants.DEFAULT_NA…
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3024:
URL: https://github.com/apache/rocketmq/pull/3024#issuecomment-865003123
[](https://coveralls.io/builds/40742938)
Coverage increased (+0.1%) to 54.152% when pulling **f2fc96987516c0cf39b34c4f15079476a0fa8d79 on yglovewms:master** into **df1d93fc8859377b92ba87c6947911281656f355 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org