You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by wo...@apache.org on 2008/09/08 17:20:37 UTC

svn commit: r693131 - in /portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl: GroupManagerImpl.java RoleManagerImpl.java UserManagerImpl.java

Author: woonsan
Date: Mon Sep  8 08:20:37 2008
New Revision: 693131

URL: http://svn.apache.org/viewvc?rev=693131&view=rev
Log:
Flattening the Principal API.
Uses new constructor with name argument.

Modified:
    portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/GroupManagerImpl.java
    portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/RoleManagerImpl.java
    portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/UserManagerImpl.java

Modified: portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/GroupManagerImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/GroupManagerImpl.java?rev=693131&r1=693130&r2=693131&view=diff
==============================================================================
--- portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/GroupManagerImpl.java (original)
+++ portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/GroupManagerImpl.java Mon Sep  8 08:20:37 2008
@@ -83,8 +83,7 @@
      */
     public Group newGroup(String name, boolean mapped)
     {
-        GroupImpl group = new GroupImpl();
-        group.setName(name);
+        GroupImpl group = new GroupImpl(name);
         group.setMapped(mapped);
         return group;
     }
@@ -94,8 +93,7 @@
      */
     public Group newTransientGroup(String name)
     {
-        TransientGroup group = new TransientGroup();
-        group.setName(name);
+        TransientGroup group = new TransientGroup(name);
         return group;
     }
 

Modified: portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/RoleManagerImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/RoleManagerImpl.java?rev=693131&r1=693130&r2=693131&view=diff
==============================================================================
--- portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/RoleManagerImpl.java (original)
+++ portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/RoleManagerImpl.java Mon Sep  8 08:20:37 2008
@@ -89,8 +89,7 @@
      */
     public Role newRole(String name, boolean mapped)
     {
-        RoleImpl role = new RoleImpl();
-        role.setName(name);
+        RoleImpl role = new RoleImpl(name);
         role.setMapped(mapped);
         return role;
     }
@@ -100,8 +99,7 @@
      */
     public Role newTransientRole(String name)
     {
-        TransientRole role = new TransientRole();
-        role.setName(name);
+        TransientRole role = new TransientRole(name);
         return role;
     }
 

Modified: portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/UserManagerImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/UserManagerImpl.java?rev=693131&r1=693130&r2=693131&view=diff
==============================================================================
--- portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/UserManagerImpl.java (original)
+++ portals/jetspeed-2/portal/branches/security-refactoring/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/UserManagerImpl.java Mon Sep  8 08:20:37 2008
@@ -224,22 +224,19 @@
 
 	public User newTransientUser(String name)
 	{
-		TransientUser user = new TransientUser();
-		user.setName(name);
+		TransientUser user = new TransientUser(name);
 		return user;
 	}
 
 	public User newUser(String name)
 	{
-		UserImpl user = new UserImpl();
-		user.setName(name);
+		UserImpl user = new UserImpl(name);
 		return user;
 	}
 
 	public User newUser(String name, boolean mapped)
 	{
-		UserImpl user = new UserImpl();
-		user.setName(name);
+		UserImpl user = new UserImpl(name);
 		user.setMapped(mapped);
 		return user;
 	}



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org