You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by ju...@apache.org on 2021/02/18 04:45:04 UTC
[apisix-dashboard] 01/01: feat: added tip on the Metrics page
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch feat-monitor-tip
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
commit ea591cc44a21b39ca5df4cf8bf61bf5b895e0c3e
Author: juzhiyuan <ju...@apache.org>
AuthorDate: Thu Feb 18 12:44:44 2021 +0800
feat: added tip on the Metrics page
---
web/src/pages/Metrics/Metrics.tsx | 14 ++++++++++++--
web/src/pages/Metrics/locales/en-US.ts | 3 ++-
web/src/pages/Metrics/locales/zh-CN.ts | 1 +
3 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/web/src/pages/Metrics/Metrics.tsx b/web/src/pages/Metrics/Metrics.tsx
index cb8d3fc..1680478 100644
--- a/web/src/pages/Metrics/Metrics.tsx
+++ b/web/src/pages/Metrics/Metrics.tsx
@@ -16,10 +16,11 @@
*/
import React, { useState, useEffect } from 'react';
import { PageHeaderWrapper } from '@ant-design/pro-layout';
-import { Empty, Button, Card } from 'antd';
+import { Empty, Button, Card, Tooltip } from 'antd';
import { history, useIntl } from 'umi';
import { getGrafanaURL } from './service';
+import { QuestionCircleOutlined } from '@ant-design/icons';
const Metrics: React.FC = () => {
const [grafanaURL, setGrafanaURL] = useState<string | undefined>();
@@ -32,7 +33,16 @@ const Metrics: React.FC = () => {
}, []);
return (
- <PageHeaderWrapper title={formatMessage({ id: 'menu.metrics' })}>
+ <PageHeaderWrapper
+ title={
+ <>
+ {formatMessage({ id: 'menu.metrics' })}
+ <Tooltip title={formatMessage({ id: 'page.metrics.tip' })}>
+ <QuestionCircleOutlined />
+ </Tooltip>
+ </>
+ }
+ >
<Card>
{!grafanaURL && (
<Empty
diff --git a/web/src/pages/Metrics/locales/en-US.ts b/web/src/pages/Metrics/locales/en-US.ts
index 7841b7e..557a370 100644
--- a/web/src/pages/Metrics/locales/en-US.ts
+++ b/web/src/pages/Metrics/locales/en-US.ts
@@ -16,5 +16,6 @@
*/
export default {
'page.metrics.empty.description.grafanaNotConfig': 'You have not configured Grafana',
- 'page.metrics.button.grafanaConfig': 'Configure Now',
+ 'page.metrics.button.grafanaConfig': 'Configure',
+ 'page.metrics.tip': 'Use browser iframe to store monitor page URL, local only.',
};
diff --git a/web/src/pages/Metrics/locales/zh-CN.ts b/web/src/pages/Metrics/locales/zh-CN.ts
index 134b1dc..5ab0397 100644
--- a/web/src/pages/Metrics/locales/zh-CN.ts
+++ b/web/src/pages/Metrics/locales/zh-CN.ts
@@ -17,4 +17,5 @@
export default {
'page.metrics.empty.description.grafanaNotConfig': '您还未配置 Grafana',
'page.metrics.button.grafanaConfig': '现在配置',
+ 'page.metrics.tip': '使用浏览器 iframe 存储监控页访问地址,仅作用于本地。',
};