You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/02 13:50:30 UTC

[GitHub] [arrow] thisisnic commented on pull request #10436: ARROW-12901: [R] Follow on to more examples

thisisnic commented on pull request #10436:
URL: https://github.com/apache/arrow/pull/10436#issuecomment-853044940


   WRT @jonkeane 's questions on the JIRA ticket:
   > https://github.com/apache/arrow/pull/10368/files#diff-9fe1a055f9a4df7088de4e0c759c20138422b8bdb9bba04ed74c7881aa787019R66-R67
   > Should this use @examplesIf ?
   
   Yep - have updated now!
   
   > https://github.com/apache/arrow/pull/10368/files#diff-0229d62b9653ff7124e6e2f202e51d46d4d8fcaf14baf83ccf8c047c7c344579R78-R80
   > These are both genuine questions, I'm not sure we want to include either or both of them:
   >   * This might be too much indirection, but would it be better/easier to use `write_dataset() here?
   Nice, that's made that code a LOT nicer to look at.
   >   * Do we want to talk about reading a partitioned dataset here?
   Yeah, I think this is probably a good place to put that - what kinds of things do you think we should mention?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org