You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2016/01/20 15:04:09 UTC
Review Request 42552: Capture package requirements that are optional
and config dependent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42552/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-14739
https://issues.apache.org/jira/browse/AMBARI-14739
Repository: ambari
Description
-------
We need a general solution. A change to the stack definition to capture
package requirements that are optional and config dependent. Something in the
line of:
* additional package - pkg_a
* install if params.install_pkg_a is true
* install_pkg_a is true if (some custom service specific condition is true)
* both install() and start() commands need to check if install_pkg_a is true and then install the package (or remove from excluded package)
* by default all additional packages are exluded
Diffs
-----
ambari-agent/src/test/python/resource_management/TestScript.py fd31910
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py 0537ec3
ambari-common/src/main/python/resource_management/libraries/script/script.py 7101386
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java 47e244f
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 97213fd
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py fdd8f5a
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py ecab844
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 7679d90
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py e894f95
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml e3e16e3
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 1d242e1
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 16218b6
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py ad4283c
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 9a42702
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py df5569e
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py c923e23
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 1748955
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 148e605
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py b28a5e0
ambari-server/src/main/resources/custom_actions/scripts/install_packages_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/metainfo.xml d80b5d1
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml ca4b5c5
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml cb0062f
ambari-server/src/test/python/custom_actions/configs/install_packages_config.json fcd7765
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json e2e9965
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 1a3b217
ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json a042dfd
Diff: https://reviews.apache.org/r/42552/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 42552: Capture package requirements that are
optional and config dependent
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42552/#review115442
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 20, 2016, 7:04 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42552/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 7:04 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-14739
> https://issues.apache.org/jira/browse/AMBARI-14739
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need a general solution. A change to the stack definition to capture
> package requirements that are optional and config dependent. Something in the
> line of:
>
> * additional package - pkg_a
> * install if params.install_pkg_a is true
> * install_pkg_a is true if (some custom service specific condition is true)
> * both install() and start() commands need to check if install_pkg_a is true and then install the package (or remove from excluded package)
> * by default all additional packages are exluded
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestScript.py fd31910
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py 0537ec3
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py PRE-CREATION
> ambari-common/src/main/python/resource_management/libraries/script/script.py 7101386
> ambari-funtest/src/test/resources/stacks/HDP/2.1.1/services/AMBARI_METRICS/metainfo.xml aea1252
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java 47e244f
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py a1d6a1d
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 97213fd
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py fdd8f5a
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py ecab844
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 7679d90
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py e894f95
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml e3e16e3
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 1d242e1
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 16218b6
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py ad4283c
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 9a42702
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py df5569e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py c923e23
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 1748955
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 148e605
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml 634b2fc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py b372085
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py 117b456
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 5866cd0
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 96c05ca
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py dcfb567
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a2131b0
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py f2524b2
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py f0f31a8
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml 72f159a
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py 580545d
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 0cf9c7d
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py b28a5e0
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/metainfo.xml 5c9e8c2
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/metainfo.xml d80b5d1
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml ca4b5c5
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/metainfo.xml ba87d8e
> ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/metainfo.xml d5db93c
> ambari-server/src/main/resources/stacks/HDP/2.2/services/SQOOP/metainfo.xml eaa4051
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml cb0062f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/metainfo.xml f184741
> ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/metainfo.xml 8d1dda1
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json fcd7765
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json e2e9965
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 1a3b217
> ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json a042dfd
>
> Diff: https://reviews.apache.org/r/42552/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 42552: Capture package requirements that are
optional and config dependent
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42552/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 5:04 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-14739
https://issues.apache.org/jira/browse/AMBARI-14739
Repository: ambari
Description
-------
We need a general solution. A change to the stack definition to capture
package requirements that are optional and config dependent. Something in the
line of:
* additional package - pkg_a
* install if params.install_pkg_a is true
* install_pkg_a is true if (some custom service specific condition is true)
* both install() and start() commands need to check if install_pkg_a is true and then install the package (or remove from excluded package)
* by default all additional packages are exluded
Diffs (updated)
-----
ambari-agent/src/test/python/resource_management/TestScript.py fd31910
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py 0537ec3
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/script/script.py 7101386
ambari-funtest/src/test/resources/stacks/HDP/2.1.1/services/AMBARI_METRICS/metainfo.xml aea1252
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java 47e244f
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py a1d6a1d
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 97213fd
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py fdd8f5a
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py ecab844
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 7679d90
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py e894f95
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml e3e16e3
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 1d242e1
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 16218b6
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py ad4283c
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 9a42702
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py df5569e
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py c923e23
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 1748955
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 148e605
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml 634b2fc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py b372085
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py 117b456
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 5866cd0
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 96c05ca
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py dcfb567
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a2131b0
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py f2524b2
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py f0f31a8
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml 72f159a
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py 580545d
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 0cf9c7d
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py b28a5e0
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/metainfo.xml 5c9e8c2
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/metainfo.xml d80b5d1
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml ca4b5c5
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/metainfo.xml ba87d8e
ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/metainfo.xml d5db93c
ambari-server/src/main/resources/stacks/HDP/2.2/services/SQOOP/metainfo.xml eaa4051
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml cb0062f
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/metainfo.xml f184741
ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/metainfo.xml 8d1dda1
ambari-server/src/test/python/custom_actions/configs/install_packages_config.json fcd7765
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json e2e9965
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 1a3b217
ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json a042dfd
Diff: https://reviews.apache.org/r/42552/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 42552: Capture package requirements that are
optional and config dependent
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42552/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 4:12 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-14739
https://issues.apache.org/jira/browse/AMBARI-14739
Repository: ambari
Description
-------
We need a general solution. A change to the stack definition to capture
package requirements that are optional and config dependent. Something in the
line of:
* additional package - pkg_a
* install if params.install_pkg_a is true
* install_pkg_a is true if (some custom service specific condition is true)
* both install() and start() commands need to check if install_pkg_a is true and then install the package (or remove from excluded package)
* by default all additional packages are exluded
Diffs (updated)
-----
ambari-agent/src/test/python/resource_management/TestScript.py fd31910
ambari-common/src/main/python/resource_management/libraries/functions/__init__.py 1ab0ff1
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py 0537ec3
ambari-common/src/main/python/resource_management/libraries/functions/package_chooser.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/script/script.py 7101386
ambari-funtest/src/test/resources/stacks/HDP/2.1.1/services/AMBARI_METRICS/metainfo.xml aea1252
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java 47e244f
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py a1d6a1d
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 97213fd
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py fdd8f5a
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py ecab844
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 7679d90
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py e894f95
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml e3e16e3
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 1d242e1
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 16218b6
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py ad4283c
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 9a42702
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py df5569e
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py c923e23
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 1748955
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 148e605
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml 634b2fc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py b372085
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py 117b456
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 5866cd0
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 96c05ca
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py dcfb567
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a2131b0
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py f2524b2
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py f0f31a8
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml 72f159a
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py 580545d
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 0cf9c7d
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py b28a5e0
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/metainfo.xml 5c9e8c2
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/metainfo.xml d80b5d1
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml ca4b5c5
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/metainfo.xml ba87d8e
ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/metainfo.xml d5db93c
ambari-server/src/main/resources/stacks/HDP/2.2/services/SQOOP/metainfo.xml eaa4051
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml cb0062f
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/metainfo.xml f184741
ambari-server/src/test/python/custom_actions/configs/install_packages_config.json fcd7765
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json e2e9965
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 1a3b217
ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json a042dfd
Diff: https://reviews.apache.org/r/42552/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 42552: Capture package requirements that are
optional and config dependent
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42552/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 4:10 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-14739
https://issues.apache.org/jira/browse/AMBARI-14739
Repository: ambari
Description
-------
We need a general solution. A change to the stack definition to capture
package requirements that are optional and config dependent. Something in the
line of:
* additional package - pkg_a
* install if params.install_pkg_a is true
* install_pkg_a is true if (some custom service specific condition is true)
* both install() and start() commands need to check if install_pkg_a is true and then install the package (or remove from excluded package)
* by default all additional packages are exluded
Diffs (updated)
-----
ambari-agent/src/test/python/resource_management/TestScript.py fd31910
ambari-common/src/main/python/resource_management/libraries/functions/__init__.py 1ab0ff1
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py 0537ec3
ambari-common/src/main/python/resource_management/libraries/functions/package_chooser.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/script/script.py 7101386
ambari-funtest/src/test/resources/stacks/HDP/2.1.1/services/AMBARI_METRICS/metainfo.xml aea1252
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java 47e244f
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py a1d6a1d
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 97213fd
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py fdd8f5a
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py ecab844
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 7679d90
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py e894f95
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml e3e16e3
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 1d242e1
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 16218b6
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py ad4283c
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 9a42702
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py df5569e
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py c923e23
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 1748955
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 148e605
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml 634b2fc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py b372085
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py 117b456
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 5866cd0
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 96c05ca
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py dcfb567
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a2131b0
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py f2524b2
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py f0f31a8
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml 72f159a
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py 580545d
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 0cf9c7d
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py b28a5e0
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/metainfo.xml 5c9e8c2
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/metainfo.xml d80b5d1
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml ca4b5c5
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/metainfo.xml ba87d8e
ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/metainfo.xml d5db93c
ambari-server/src/main/resources/stacks/HDP/2.2/services/SQOOP/metainfo.xml eaa4051
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml cb0062f
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/metainfo.xml f184741
ambari-server/src/test/python/custom_actions/configs/install_packages_config.json fcd7765
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json e2e9965
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 1a3b217
ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json a042dfd
Diff: https://reviews.apache.org/r/42552/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 42552: Capture package requirements that are
optional and config dependent
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42552/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 3:21 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-14739
https://issues.apache.org/jira/browse/AMBARI-14739
Repository: ambari
Description
-------
We need a general solution. A change to the stack definition to capture
package requirements that are optional and config dependent. Something in the
line of:
* additional package - pkg_a
* install if params.install_pkg_a is true
* install_pkg_a is true if (some custom service specific condition is true)
* both install() and start() commands need to check if install_pkg_a is true and then install the package (or remove from excluded package)
* by default all additional packages are exluded
Diffs (updated)
-----
ambari-agent/src/test/python/resource_management/TestScript.py fd31910
ambari-common/src/main/python/resource_management/libraries/functions/__init__.py 1ab0ff1
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py 0537ec3
ambari-common/src/main/python/resource_management/libraries/functions/is_lzo_enabled.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/should_install_phoenix.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/script/script.py 7101386
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java 47e244f
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 97213fd
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py fdd8f5a
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py ecab844
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 7679d90
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py e894f95
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml e3e16e3
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 1d242e1
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 16218b6
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py ad4283c
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 9a42702
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py df5569e
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py c923e23
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 1748955
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 148e605
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py b28a5e0
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/metainfo.xml d80b5d1
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml ca4b5c5
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml cb0062f
ambari-server/src/test/python/custom_actions/configs/install_packages_config.json fcd7765
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json e2e9965
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 1a3b217
ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json a042dfd
Diff: https://reviews.apache.org/r/42552/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk