You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by kfeagle <gi...@git.apache.org> on 2017/03/03 09:45:58 UTC
[GitHub] incubator-weex pull request #32: Ios bugfix textarea 0.11 dev
GitHub user kfeagle opened a pull request:
https://github.com/apache/incubator-weex/pull/32
Ios bugfix textarea 0.11 dev
fixbug:
when text overflow ,text will show
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kfeagle/incubator-weex ios-bugfix-textarea-0.11-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 293db90a5a9f7af7cbc459021ac82a38f737018d
Author: kfeagle <su...@163.com>
Date: 2017-03-02T12:22:47Z
Merge branch 'apache/0.11-dev' into 0.11-dev
commit 7c1b0a5a2044bac5d516761f1847dee3657453e2
Author: kfeagle <su...@163.com>
Date: 2017-03-03T05:50:49Z
+ [ios] fix iOS textarea bug
commit c030aef945dcfdeec57c282dc33991326a55ef32
Author: kfeagle <su...@163.com>
Date: 2017-03-03T05:54:33Z
+ [ios] delete no use code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #32: * [ios] bugfix textarea overflow and rows u...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #32: Ios bugfix textarea 0.11 dev
Posted by kfeagle <gi...@git.apache.org>.
Github user kfeagle commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/32#discussion_r104287286
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXEditComponent.m ---
@@ -342,6 +354,13 @@ - (void)updateAttributes:(NSDictionary *)attributes
_returnKeyType = [WXConvert UIReturnKeyType:attributes[@"returnKeyType"]];
[self setReturnKeyType:_returnKeyType];
}
+ if (attributes[@"rows"]) {
--- End diff --
update row
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #32: Ios bugfix textarea 0.11 dev
Posted by kfeagle <gi...@git.apache.org>.
Github user kfeagle commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/32#discussion_r104287275
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXEditComponent.m ---
@@ -264,6 +272,10 @@ -(void)setFont:(UIFont *)font
{
}
+-(void)setRows:(NSUInteger)rows
--- End diff --
will overwrite by textarea
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #32: Ios bugfix textarea 0.11 dev
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/32
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Message">
1 Message
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:book:</td>
<td data-sticky="false">Executed 53 tests, with 0 failures (0 unexpected) in 60.503 (61.230) seconds</td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---