You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "jzhuge (via GitHub)" <gi...@apache.org> on 2023/01/30 20:09:43 UTC

[GitHub] [spark] jzhuge commented on pull request #39796: [SPARK-39800][SQL][WIP] DataSourceV2: View Support

jzhuge commented on PR #39796:
URL: https://github.com/apache/spark/pull/39796#issuecomment-1409264105

   TODOs and comments:
   
   - More unit tests
   - Conform to “v2 command framework”. ResolveCatalogs seem to have too much extra view code, but that cleanup might require migrating more SQL commands to “v2 command framework”. Maybe a good opportunity to split PR.
   - Further cleanup/simplify/unify code, especially around `ResolvedV2View`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org