You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by FrankQiao <gi...@git.apache.org> on 2016/04/23 16:59:59 UTC

[GitHub] sqoop pull request: Branch 1.99.6

GitHub user FrankQiao opened a pull request:

    https://github.com/apache/sqoop/pull/19

    Branch 1.99.6

    When completing the TO part of a job, people cannot state custom SQL statement by any means:
    1. When both TableName and SQL statement are provided, it reports the'GENERIC_JDBC_CONNECTOR_0007("The table name and the table sql cannot be specified together")' exception.
    2. When only the SQL statement is provided, it reports the 'Both table name and SQL cannot be specified' exception.
    
    The modification we have made is simply to allow the TableName and the SQL statement can be input together and in this case, the SQL have the higher priority to be executed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FrankQiao/sqoop branch-1.99.6

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sqoop/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit 048c6dc95d47c8b30e3a365c2a0fbbfe5a577eb9
Author: FuqiaoWang <wa...@mininglamp.com>
Date:   2016-04-23T13:12:50Z

    <<committed by wfq>>bug修复:只填写Table SQL
    statement项时，报不支持提取tableName错误，填写tableName项和Table SQL
    statement项时，报二者不可同时添加错误。

commit 493fcee31a6ac52bad5fe70f3920a2738fcff597
Author: FrankQiao <42...@qq.com>
Date:   2016-04-23T14:47:18Z

    When completing the TO part of a job, people cannot state custom SQL
    statement by any means. 
    When both TableName and SQL statement are provided, it reports the BOTH
    exception:GENERIC_JDBC_CONNECTOR_0007("The table name and the table sql
    cannot be specified together").
    When only the SQL statement is provided, it reports the CANNOT extract
    exception:Both table name and SQL cannot be specified.
    We simply modify the corresponding branch logic judgment and removed at
    the same time fill tableName, Table SQL validation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] sqoop pull request: [SQOOP-2916]

Posted by FuqiaoWang <gi...@git.apache.org>.
Github user FuqiaoWang commented on the pull request:

    https://github.com/apache/sqoop/pull/19#issuecomment-216464764
  
    Thank you for your reply @afine, I have submitted my patch to:https://issues.apache.org/jira/browse/SQOOP-2916 .I would be very happy if you can review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] sqoop pull request: Branch 1.99.6

Posted by afine <gi...@git.apache.org>.
Github user afine commented on the pull request:

    https://github.com/apache/sqoop/pull/19#issuecomment-214450599
  
    Hi @FuqiaoWang. We typically use jira and review board for handling issues and patches (the github exists purely as a mirror). Please submit your patch to: https://issues.apache.org/jira/secure/Dashboard.jspa and I would be happy to review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---