You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/17 01:40:45 UTC

[GitHub] [superset] suddjian commented on a change in pull request #19231: chore!: remove `ENABLE_REACT_CRUD_VIEWS` feature flag (permanently enable)

suddjian commented on a change in pull request #19231:
URL: https://github.com/apache/superset/pull/19231#discussion_r828630166



##########
File path: superset-frontend/src/SqlLab/components/App/index.jsx
##########
@@ -96,29 +94,14 @@ class App extends React.PureComponent {
   }
 
   render() {
-    let content;
     if (this.state.hash && this.state.hash === '#search') {
-      if (isFeatureEnabled(FeatureFlag.ENABLE_REACT_CRUD_VIEWS)) {

Review comment:
       I kept this logic the same as before, but the logic doesn't look quite right to me. Shouldn't we be rendering with react instead of `location.replace`ing when react crud is enabled?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org