You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "prateekm (via GitHub)" <gi...@apache.org> on 2023/02/01 01:01:40 UTC
[GitHub] [samza] prateekm commented on a diff in pull request #1650: Make blob store related retry tunables configurable
prateekm commented on code in PR #1650:
URL: https://github.com/apache/samza/pull/1650#discussion_r1092643587
##########
samza-core/src/main/java/org/apache/samza/config/BlobStoreConfig.java:
##########
@@ -33,16 +37,16 @@ public class BlobStoreConfig extends MapConfig {
// -1 for RetryPolicy means unlimited retries. Retry is limited by max retry duration, rather than count of retries.
public static final int DEFAULT_RETRY_POLICY_MAX_RETRIES = -1;
public static final String RETRY_POLICY_MAX_RETRY_DURATION_MILLIS = RETRY_POLICY_PREFIX + "max.retry.duration.millis";
- public static final long DEFAULT_RETRY_POLICY_MAX_RETRY_DURATION_MILLIS = 10 * 60 * 1000; // 10 mins
+ public static final long DEFAULT_RETRY_POLICY_MAX_RETRY_DURATION_MILLIS = 15 * 60 * 1000; // 15 mins
public static final String RETRY_POLICY_BACKOFF_DELAY_MILLIS = RETRY_POLICY_PREFIX + "backoff.delay.millis";
public static final long DEFAULT_RETRY_POLICY_BACKOFF_DELAY_MILLIS = 100;
public static final String RETRY_POLICY_BACKOFF_MAX_DELAY_MILLIS = RETRY_POLICY_PREFIX + "backoff.max.delay.millis";
public static final long DEFAULT_RETRY_POLICY_BACKOFF_MAX_DELAY_MILLIS = 312500;
public static final String RETRY_POLICY_BACKOFF_DELAY_FACTOR = RETRY_POLICY_PREFIX + "backoff.delay.factor";
public static final int DEFAULT_RETRY_POLICY_BACKOFF_DELAY_FACTOR = 5;
- public static final String RETRY_POLICY_JITTER_FACTOR_MILLIS = RETRY_POLICY_PREFIX + "jitter.factor.millis";
+ public static final String RETRY_POLICY_JITTER_FACTOR = RETRY_POLICY_PREFIX + "jitter.factor";
// random retry delay between -100 to 100 millisecond
- public static final long DEFAULT_RETRY_POLICY_JITTER_FACTOR_MILLIS = 100;
+ public static final double DEFAULT_RETRY_POLICY_JITTER_FACTOR = 0.1;
Review Comment:
Fix comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org