You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philippe M. Chiasson" <go...@cpan.org> on 2004/02/18 00:47:01 UTC
forcing IPv4 configuration [was:Apache::Test on FreeBSD]
On Tue, 2004-02-17 at 15:25 -0800, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> [...]
> >>I'll try to summarize what you said in a table. The following approaches work
> >>for Listen:
> >>
> >>Apache \ OS | IPV4 | IPV6
> >>--------------------------------------------
> >>--enable-v4-mapped | 80 | 80
> >>--disable-v4-mapped | can't happen | 127.0.0.1:80
> >>
> >>Am I correct? So we need to use 'Listen 127.0.0.1:80' only when we see:
> >>
> >>-D APR_HAVE_IPV6 (IPv4-mapped addresses disabled), .i.e. --disable-v4-mapped
> >>
> >>otherwise the old '80' is fine.
> >
> >
> > Yes, that's the way I've experienced/understood it on my trusty OpenBSD
> > box (and Linux with IPv6)
>
> OK, so how about you go ahead and commit your original patch (hardcoding
> 127.0.0.1). And log the above table in the Apache-Test/ToDo list, to may be
> check have 127.0.0.1 hardcoded only if --disable-v4-mapped is detected, in
> case someone will have problems with that change.
>
One last review first please ;-)
>
> --
> __________________________________________________________________
> Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/ mod_perl Guide ---> http://perl.apache.org
> mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org http://ticketmaster.comIndex: Apache-Test/Changes
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/Changes,v
retrieving revision 1.87
diff -u -I$Id -r1.87 Changes
--- Apache-Test/Changes 9 Feb 2004 18:00:55 -0000 1.87
+++ Apache-Test/Changes 17 Feb 2004 23:46:30 -0000
@@ -8,6 +8,9 @@
=item 1.08_dev
+Hard-code listen directive to 127.0.0.1, solving problems for people
+with IPv4 & IPv6 address until a better solution is found [Gozer]
+
prefix Apache::TestTrace (non-colour mode) messages with the loglevel,
similar to what Apache does. [Stas]
Index: Apache-Test/ToDo
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/ToDo,v
retrieving revision 1.7
diff -u -I$Id -r1.7 ToDo
--- Apache-Test/ToDo 26 Sep 2003 16:55:55 -0000 1.7
+++ Apache-Test/ToDo 17 Feb 2004 23:46:30 -0000
@@ -4,6 +4,16 @@
Philippe posted patch here:
http://marc.theaimsgroup.com/?l=apache-modperl-
dev&m=105514290024419&w=2
+ For now, 127.0.0.1 will be hardcoded in the Listen directive, but a
better
+ method would use this table:
+
+ Apache \ OS | IPV4 | IPV6
+ --------------------------------------------
+ --enable-v4-mapped | 80 | 80
+ --disable-v4-mapped | can't happen | 127.0.0.1:80
+
+ To more correctly pick the right Listen flavor.
+
- Apache-Test assumes that any core file found under t/ was generated
by httpd, (and suggests the gdb invoking command) which is incorrect
in some cases. For example t/TEST -config, which is run by bin/perl,
Index: Apache-Test/lib/Apache/TestConfig.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/
TestConfig.pm,v
retrieving revision 1.204
diff -u -I$Id -r1.204 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm 31 Jan 2004 01:53:09 -
0000 1.204
+++ Apache-Test/lib/Apache/TestConfig.pm 17 Feb 2004 23:46:30 -0000
@@ -1002,7 +1002,7 @@
my @out_config = ();
if ($self->{vhosts}->{$module}->{namebased} < 2) {
#extra config that should go *outside* the <VirtualHost ...>
- @out_config = ([Listen => $port]);
+ @out_config = ([Listen => '127.0.0.1:' . $port]);
if ($self->{vhosts}->{$module}->{namebased}) {
push @out_config => [NameVirtualHost => "*:$port"];
@@ -1750,7 +1750,7 @@
__DATA__
-Listen @Port@
+Listen 127.0.0.1:@Port@
ServerRoot "@ServerRoot@"
DocumentRoot "@DocumentRoot@"
Index: Apache-Test/lib/Apache/TestConfigPerl.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/
TestConfigPerl.pm,v
retrieving revision 1.81
diff -u -I$Id -r1.81 TestConfigPerl.pm
--- Apache-Test/lib/Apache/TestConfigPerl.pm 24 Nov 2003 07:57:30 -
0000 1.81
+++ Apache-Test/lib/Apache/TestConfigPerl.pm 17 Feb 2004 23:46:30 -0000
@@ -207,7 +207,7 @@
sub set_connection_handler {
my($self, $module, $args) = @_;
my $port = $self->new_vhost($module);
- $self->postamble(Listen => $port);
+ $self->postamble(Listen => '127.0.0.1:' . $port);
}
my %add_hook_config = (
Index: t/response/TestApache/conftree.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/response/TestApache/conftree.pm,v
retrieving revision 1.7
diff -u -I$Id -r1.7 conftree.pm
--- t/response/TestApache/conftree.pm 8 Oct 2003 13:28:14 -0000 1.7
+++ t/response/TestApache/conftree.pm 17 Feb 2004 23:46:30 -0000
@@ -27,9 +27,9 @@
ok $tree;
- my $port = $tree->lookup('Listen');
+ my $listen = $tree->lookup('Listen');
- ok t_cmp($vars->{port}, $port);
+ ok t_cmp('127.0.0.1:' . $vars->{port}, $listen);
my $documentroot = $tree->lookup('DocumentRoot');
Re: forcing IPv4 configuration [was:Apache::Test on FreeBSD]
Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
[...]
> One last review first please ;-)
+1
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org