You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/02 00:07:49 UTC
[GitHub] [tvm] slyubomirsky opened a new pull request, #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
slyubomirsky opened a new pull request, #12682:
URL: https://github.com/apache/tvm/pull/12682
TVM has recently switched to C++17. CUDA support with C++17 requires CMake past version 3.18, according to @vinx13. However, the current CMake version check in `CMakeLists.txt` is not checking for the CMake version; this PR updates the version check.
Bug that prompted this: When building with CMake version 3.16 I had the following error: `CUDA_STANDARD is set to invalid value '17'`. Upgrading to the latest CMake (3.24) fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1234960511
Should the version check be conditional, then? I am not especially familiar with CMake but I imagine it's probably possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1248705174
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1234988344
I don't have much idea how to do such a check if we want to condition whether or not NVCC is used, but it seems possible if we want to warn globally no matter if nvcc is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1261463324
Thanks for the reply. Rebasing as advised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1234952751
Interesting, it looks like the CI's CMake version is below 3.18. Is it not using C++17?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
driazati commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1239994456
#12131 just merged, we have to update the Docker images to include that before this PR can pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12682:
URL: https://github.com/apache/tvm/pull/12682#discussion_r961193173
##########
CMakeLists.txt:
##########
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.2)
+cmake_minimum_required(VERSION 3.18)
Review Comment:
can you also update the requirements in `install/from_source.rst` to match?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
driazati commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1259989912
Sorry for the delay, #12906 included a Docker image tag update so they should all be on cmake 3.18+ plus now, a rebase on `main` should get this PR working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1235900395
Ah, I see the last change overlaps with @leandron's PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1239990732
Is the CI using a higher version of CMake? If not, I think the errors will continue :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1255542976
Hm, some of the builds still use different versions of CMake. Any pointers on where the CMake versions for those are defined? I would be glad to make the changes myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on a diff in pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on code in PR #12682:
URL: https://github.com/apache/tvm/pull/12682#discussion_r961204692
##########
CMakeLists.txt:
##########
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.2)
+cmake_minimum_required(VERSION 3.18)
Review Comment:
Will do, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1234956424
Likely nvcc is not used in the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1239811138
looks like some issues with the CI, but retriggering as they may be unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
driazati commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1247001583
some of the images were updated to use 3.18 but not all of them, #12774 should clean up the rest so once that is merged and updated on the images this PR should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1244459321
@driazati when do we expect there to be an update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1241394490
Per [https://github.com/apache/tvm/pull/12744](this PR), should I make the minimum version higher?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati merged pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
driazati merged PR #12682:
URL: https://github.com/apache/tvm/pull/12682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1235567660
shall we also update https://github.com/apache/tvm/blob/main/docker/install/ubuntu_install_cmake_source.sh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #12682: [Bugfix][CMake] Update the minimum CMake version to 3.18
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on PR #12682:
URL: https://github.com/apache/tvm/pull/12682#issuecomment-1235891340
Glad to hear the CI's CMake will be updated. I'll also update the install script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org