Change in asterixdb[master]: Change the API for writing and reading metadata pages

["Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>]

Ian Maxon has posted comments on this change.

Change subject: Change the API for writing and reading metadata pages
......................................................................


Patch Set 9:

(3 comments)

Only one real substantial comment, but aside from that I think it is good to go.

https://asterix-gerrit.ics.uci.edu/#/c/1396/9/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java
File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java:

Line 393:                                 fileProperties.initialize(filePath, fileSize, replicaId, false, -1L, false);
Might as well use the named variable here too.


https://asterix-gerrit.ics.uci.edu/#/c/1396/9/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java:

Line 251:         } else {
It would be good if put checked if there is actually room to put the value. Either that or the calls to this should always call getSpace() first.


https://asterix-gerrit.ics.uci.edu/#/c/1396/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java:

Line 746:                 } else {
> hmmm, this is interesting. It is not much of a bug but before, we had an al
Per our quick chat, it would be good to add a TODO here or something so whoever might come across this gets why this is called from within the tree itself rather than the LSM harness.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1396
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iadad522ab5568677aa816c74fc1d63acad505380
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes