You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2023/01/10 03:39:03 UTC

[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1368: ORC-1352: [C++] Remove `ORC_[NOEXCEPT|NULLPTR|OVERRIDE|UNIQUE_PTR]` macro usages

dongjoon-hyun commented on code in PR #1368:
URL: https://github.com/apache/orc/pull/1368#discussion_r1065305782


##########
c++/include/orc/orc-config.hh.in:
##########
@@ -25,6 +25,7 @@
   #include <stdint.h>
 #endif
 
+// Following MACROS should be keeped for backward compatibility.

Review Comment:
   Got it. Thank you. I agree with you. We can do that later separately if needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org