[GitHub] [spark] MaxGekk commented on pull request #32267: [SPARK-35170][SQL] Extend `BinaryOperator` by `SubtractDates` and `SubtractTimestamps`

[GitBox <gi...@apache.org>]

MaxGekk commented on pull request #32267:
URL: https://github.com/apache/spark/pull/32267#issuecomment-823940810


   @gengliangwang @cloud-fan FYI, this PR changes behavior in errors slightly (I guess it is not critical) :
   ```
   [info] - typeCoercion/native/promoteStrings.sql *** FAILED *** (5 seconds, 764 milliseconds)
   [info]   typeCoercion/native/promoteStrings.sql
   [info]   Expected "...data type mismatch: [argument 1 requires timestamp type, however, ''1'' is of string type].; line 1 pos 7", but got "...data type mismatch: [differing types in '('1' - CAST('2017-12-11 09:30:00.0' AS TIMESTAMP))' (string and timestamp)].; line 1 pos 7" Result did not match for query #23
   ```
   ```
   [info]   typeCoercion/native/decimalPrecision.sql
   [info]   Expected "...data type mismatch: [argument 2 requires timestamp type, however, 'CAST(1 AS DECIMAL(3,0))' is of decimal(3,0) type].; line 1 pos 7", but got "...data type mismatch: [differing types in '(CAST('2017-12-11 09:30:00.0' AS TIMESTAMP) - CAST(1 AS DECIMAL(3,0)))' (timestamp and decimal(3,0))].; line 1 pos 7" Result did not match for query #121
   [info]   SELECT cast('2017-12-11 09:30:00.0' as timestamp) - cast(1 as decimal(3, 0)) FROM t (SQLQueryTestSuite.scala:459)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org