You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/15 18:14:43 UTC

[GitHub] [beam] boyuanzz commented on a change in pull request #14226: Make beam_fn_api, use_runner_v2, and use_unified_worker all trigger the same behavior in the SDK

boyuanzz commented on a change in pull request #14226:
URL: https://github.com/apache/beam/pull/14226#discussion_r594575058



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/View.java
##########
@@ -263,8 +263,8 @@ private AsList() {}
 
       // TODO(BEAM-10097): Make this the default expansion for all portable runners.
       if (hasExperiment(input.getPipeline().getOptions(), "beam_fn_api")
-          && (hasExperiment(input.getPipeline().getOptions(), "use_runner_v2")
-              || hasExperiment(input.getPipeline().getOptions(), "use_unified_worker"))) {
+          || hasExperiment(input.getPipeline().getOptions(), "use_runner_v2")

Review comment:
       Is it possible for us to only check `beam_fn_api` here and below since we now are thinking `beam_fn_api` == `use_runner_v2` == `use_unified_worker`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org