[jira] [Commented] (HBASE-15027) Refactor the way the CompactedHFileDischarger threads are created

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068011#comment-15068011 ] 

Hadoop QA commented on HBASE-15027:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12779021/HBASE-15027.patch
  against master branch at commit 6e2c5d216eb1f4cacad7c5d7ed43b67785cabb67.
  ATTACHMENT ID: 12779021

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated new checkstyle errors. Check build console for list of new errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.TestHeapSize

    {color:green}+1 zombies{color}. No zombie tests found running at the end of the build.

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16970//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16970//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16970//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16970//console

This message is automatically generated.

> Refactor the way the CompactedHFileDischarger threads are created
> -----------------------------------------------------------------
>
>                 Key: HBASE-15027
>                 URL: https://issues.apache.org/jira/browse/HBASE-15027
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15027.patch
>
>
> As per suggestion given over in HBASE-14970, if we need to create a single thread pool service for the CompactionHFileDischarger we need to create an exectuor service in the RegionServer level and create discharger handler threads (Event handlers) and pass the Event to the new Exectuor service that we create  for the compaction hfiles discharger. What should be the default number of threads here?  If a HRS holds 100 of regions - will 10 threads be enough?  This issue will try to resolve this with tests and discussions and suitable patch will be updated in HBASE-14970 for branch-1 once this is committed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)