You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2009/08/27 23:25:26 UTC
Re: svn commit: r38975 - trunk/subversion/include
On Thu, Aug 27, 2009 at 16:47, Blair Zajac<bl...@orcaware.com> wrote:
> Author: blair
> Date: Thu Aug 27 13:47:07 2009
> New Revision: 38975
>
> Log:
> Coding style tweak.
>
> * subversion/include/svn_io.h
> (svn_stream_set_line_transformer_callback):
> Move the arguments onto their own line so there is no lint
> wrapping of a single argument.
>
> Modified:
> trunk/subversion/include/svn_io.h
>
> Modified: trunk/subversion/include/svn_io.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_io.h?pathrev=38975&r1=38974&r2=38975
> ==============================================================================
> --- trunk/subversion/include/svn_io.h Thu Aug 27 13:44:13 2009 (r38974)
> +++ trunk/subversion/include/svn_io.h Thu Aug 27 13:47:07 2009 (r38975)
> @@ -765,9 +765,9 @@ svn_stream_set_line_filter_callback(svn_
> * @a line_transformer_cb.
> * @since New in 1.7. */
> void
> -svn_stream_set_line_transformer_callback(svn_stream_t *stream,
> - svn_io_line_transformer_cb_t
> - line_transformer_cb);
> +svn_stream_set_line_transformer_callback
> + (svn_stream_t *stream,
> + svn_io_line_transformer_cb_t line_transformer_cb);
That parentheses should not have been pulled down to a second line. It
introduces whitespace between the name and paren (no longer allowed,
per style), so it doesn't follow current convention. I believe we also
have some automated scripts that look for function names, and this
will break those (in trunk/build/).
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388058
Re: svn commit: r38975 - trunk/subversion/include
Posted by Blair Zajac <bl...@orcaware.com>.
Greg Stein wrote:
> On Fri, Aug 28, 2009 at 00:20, Blair Zajac<bl...@orcaware.com> wrote:
>> Greg Stein wrote:
>>> On Thu, Aug 27, 2009 at 20:10, Blair Zajac<bl...@orcaware.com> wrote:
>>>> Greg Stein wrote:
>>>> That's the current standard style throughout the code. If we want to
>>>> change
>>>> it, someone should go through the entire code base and fix it.
>>> There is no current style of a space before a paren. Point me at the
>>> other places, and I'll change them.
>> Thanks! I found a few more in svn_client.h, svn_cmdline.h, svn_delta.h. I
>> stopped after that and didn't look through any of our private headers.
>
> Thanks. I searched for all declarations in that pattern in include/
> and fixed those in r38980. There are probably more in private headers
> elsewhere, but we can at least put our best foot forward :-)
That's great.
Thanks,
Blair
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388314
Re: svn commit: r38975 - trunk/subversion/include
Posted by Greg Stein <gs...@gmail.com>.
On Fri, Aug 28, 2009 at 00:20, Blair Zajac<bl...@orcaware.com> wrote:
> Greg Stein wrote:
>>
>> On Thu, Aug 27, 2009 at 20:10, Blair Zajac<bl...@orcaware.com> wrote:
>>>
>>> Greg Stein wrote:
>>> That's the current standard style throughout the code. If we want to
>>> change
>>> it, someone should go through the entire code base and fix it.
>>
>> There is no current style of a space before a paren. Point me at the
>> other places, and I'll change them.
>
> Thanks! I found a few more in svn_client.h, svn_cmdline.h, svn_delta.h. I
> stopped after that and didn't look through any of our private headers.
Thanks. I searched for all declarations in that pattern in include/
and fixed those in r38980. There are probably more in private headers
elsewhere, but we can at least put our best foot forward :-)
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388176
Re: svn commit: r38975 - trunk/subversion/include
Posted by Blair Zajac <bl...@orcaware.com>.
Greg Stein wrote:
> On Thu, Aug 27, 2009 at 20:10, Blair Zajac<bl...@orcaware.com> wrote:
>> Greg Stein wrote:
>> That's the current standard style throughout the code. If we want to change
>> it, someone should go through the entire code base and fix it.
>
> There is no current style of a space before a paren. Point me at the
> other places, and I'll change them.
Thanks! I found a few more in svn_client.h, svn_cmdline.h, svn_delta.h. I
stopped after that and didn't look through any of our private headers.
Blair
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388079
Re: svn commit: r38975 - trunk/subversion/include
Posted by Greg Stein <gs...@gmail.com>.
On Thu, Aug 27, 2009 at 20:10, Blair Zajac<bl...@orcaware.com> wrote:
> Greg Stein wrote:
>>
>> On Thu, Aug 27, 2009 at 16:47, Blair Zajac<bl...@orcaware.com> wrote:
>>>
>>> Author: blair
>>> Date: Thu Aug 27 13:47:07 2009
>>> New Revision: 38975
>>>
>>> Log:
>>> Coding style tweak.
>>>
>>> * subversion/include/svn_io.h
>>> (svn_stream_set_line_transformer_callback):
>>> Move the arguments onto their own line so there is no lint
>>> wrapping of a single argument.
>>>
>>> Modified:
>>> trunk/subversion/include/svn_io.h
>>>
>>> Modified: trunk/subversion/include/svn_io.h
>>> URL:
>>> http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_io.h?pathrev=38975&r1=38974&r2=38975
>>>
>>> ==============================================================================
>>> --- trunk/subversion/include/svn_io.h Thu Aug 27 13:44:13 2009
>>> (r38974)
>>> +++ trunk/subversion/include/svn_io.h Thu Aug 27 13:47:07 2009
>>> (r38975)
>>> @@ -765,9 +765,9 @@ svn_stream_set_line_filter_callback(svn_
>>> * @a line_transformer_cb.
>>> * @since New in 1.7. */
>>> void
>>> -svn_stream_set_line_transformer_callback(svn_stream_t *stream,
>>> - svn_io_line_transformer_cb_t
>>> - line_transformer_cb);
>>> +svn_stream_set_line_transformer_callback
>>> + (svn_stream_t *stream,
>>> + svn_io_line_transformer_cb_t line_transformer_cb);
>>
>> That parentheses should not have been pulled down to a second line. It
>> introduces whitespace between the name and paren (no longer allowed,
>> per style), so it doesn't follow current convention. I believe we also
>> have some automated scripts that look for function names, and this
>> will break those (in trunk/build/).
>
> That's the current standard style throughout the code. If we want to change
> it, someone should go through the entire code base and fix it.
There is no current style of a space before a paren. Point me at the
other places, and I'll change them.
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388075
Re: svn commit: r38975 - trunk/subversion/include
Posted by Blair Zajac <bl...@orcaware.com>.
Greg Stein wrote:
> On Thu, Aug 27, 2009 at 16:47, Blair Zajac<bl...@orcaware.com> wrote:
>> Author: blair
>> Date: Thu Aug 27 13:47:07 2009
>> New Revision: 38975
>>
>> Log:
>> Coding style tweak.
>>
>> * subversion/include/svn_io.h
>> (svn_stream_set_line_transformer_callback):
>> Move the arguments onto their own line so there is no lint
>> wrapping of a single argument.
>>
>> Modified:
>> trunk/subversion/include/svn_io.h
>>
>> Modified: trunk/subversion/include/svn_io.h
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_io.h?pathrev=38975&r1=38974&r2=38975
>> ==============================================================================
>> --- trunk/subversion/include/svn_io.h Thu Aug 27 13:44:13 2009 (r38974)
>> +++ trunk/subversion/include/svn_io.h Thu Aug 27 13:47:07 2009 (r38975)
>> @@ -765,9 +765,9 @@ svn_stream_set_line_filter_callback(svn_
>> * @a line_transformer_cb.
>> * @since New in 1.7. */
>> void
>> -svn_stream_set_line_transformer_callback(svn_stream_t *stream,
>> - svn_io_line_transformer_cb_t
>> - line_transformer_cb);
>> +svn_stream_set_line_transformer_callback
>> + (svn_stream_t *stream,
>> + svn_io_line_transformer_cb_t line_transformer_cb);
>
> That parentheses should not have been pulled down to a second line. It
> introduces whitespace between the name and paren (no longer allowed,
> per style), so it doesn't follow current convention. I believe we also
> have some automated scripts that look for function names, and this
> will break those (in trunk/build/).
That's the current standard style throughout the code. If we want to change it,
someone should go through the entire code base and fix it.
Blair
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388074