[GitHub] [incubator-superset] willbarrett commented on a change in pull request #10324: feat: add optional prophet forecasting functionality to chart data api

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #10324:
URL: https://github.com/apache/incubator-superset/pull/10324#discussion_r455386737



##########
File path: tests/pandas_postprocessing_tests.py
##########
@@ -508,3 +509,119 @@ def test_contribution(self):
         self.assertListEqual(df.columns.tolist(), ["a", "b"])
         self.assertListEqual(series_to_list(column_df["a"]), [0.25, 0.75])
         self.assertListEqual(series_to_list(column_df["b"]), [0.1, 0.9])
+
+    def test_prophet_incorrect_values(self):

Review comment:
       Breaking this up into a test for each incorrect value type may make debugging test failures easier down the road.

##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -544,3 +563,105 @@ def contribution(
     if temporal_series is not None:
         contribution_df.insert(0, DTTM_ALIAS, temporal_series)
     return contribution_df
+
+
+def prophet(  # pylint: disable=too-many-arguments,too-many-locals

Review comment:
       Could this function be broken up? Generally comments in a large function like this are a good place to draw divisions




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org