You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2026/06/22 05:00:12 UTC

[PR] fix: gate element_at input types [datafusion-comet]

manuzhang opened a new pull request, #4702:
URL: https://github.com/apache/datafusion-comet/pull/4702

   ## Which issue does this PR close?
   
   Part of apache/datafusion-comet#4505.
   
   This PR does not address apache/datafusion-comet#4680 because that follow-up is assigned separately.
   
   ## Rationale for this change
   
   `element_at` supports array and map inputs in Spark, but Comet only implements the array path. Reporting the map-input fallback through `getSupportLevel` keeps unsupported map inputs documented and handled consistently.
   
   ## What changes are included in this PR?
   
   - Moves the `MapType` input fallback for `ElementAt` into `getSupportLevel`.
   - Reuses the unsupported map-input reason in generated support documentation.
   - Adds SQL fallback coverage for `element_at` on map inputs.
   
   ## How are these changes tested?
   
   - Adds SQL tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: gate element_at input types [datafusion-comet]

Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang closed pull request #4702: fix: gate element_at input types
URL: https://github.com/apache/datafusion-comet/pull/4702


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: gate element_at input types [datafusion-comet]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #4702:
URL: https://github.com/apache/datafusion-comet/pull/4702#issuecomment-4780750769

   Thanks for working on this @manuzhang. I think this PR may conflict with https://github.com/apache/datafusion-comet/pull/4697?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org