You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/07/23 07:18:22 UTC

[GitHub] [logging-log4j2] schlosna commented on a diff in pull request #974: LOG4J2-3560: Logger$PrivateConfig.filter(Level, Marker, String) varargs does not allocate

schlosna commented on code in PR #974:
URL: https://github.com/apache/logging-log4j2/pull/974#discussion_r928090389


##########
log4j-core/src/main/java/org/apache/logging/log4j/core/Logger.java:
##########
@@ -53,6 +53,9 @@ public class Logger extends AbstractLogger implements Supplier<LoggerConfig> {
 
     private static final long serialVersionUID = 1L;
 
+    // Used to avoid allocations for empty varargs
+    private static final Object[] EMPTY_VARARGS = new Object[0];

Review Comment:
   Thanks for the quick review! updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org