You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2008/07/31 18:37:32 UTC
Re: svn commit: propchange - r32343 - svn:log
stylesen@tigris.org wrote:
> Author: stylesen
> Revision: 32343
> Property Name: svn:log
> Action: modified
>
> Property diff:
> --- old property value
> +++ new property value
> @@ -4,12 +4,11 @@ allocated from a pool that is not cleare
> external item.
>
> * subversion/libsvn_client/externals.c
> - (handle_external_item_change_baton):
> - Add a new non-iterpool to this struct for paths and URLs that
> - need to outlive any one iteration over any one external item.
> - (handle_externals_desc_change):
> - Set the handle_external_item_change_baton pool field.
> - (handle_external_item_change):
> - Pass the pool and not the iter_pool to resolve_relative_external_url()
> - so the absolute URL placed into the hash table lives past the
> - iter_pool.
> + (handle_external_item_change_baton): Add a new non-iterpool to this struct
> + for paths and URLs that need to outlive any one iteration over any one
> + external item.
> + (handle_externals_desc_change): Set the handle_external_item_change_baton
> + pool field.
> + (handle_external_item_change): Pass the pool and not the iter_pool to
> + resolve_relative_external_url() so the absolute URL placed into the hash
> + table lives past the iter_pool.
Would you mind reverting the formatting commit. That's the style I've used
since I joined the committer and I like it more then the other format when the
text starting on the same line at the function name.
Thanks,
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: propchange - r32343 - svn:log
Posted by Blair Zajac <bl...@orcaware.com>.
Senthil Kumaran S wrote:
> Blair Zajac wrote:
>> Would you mind reverting the formatting commit. That's the style I've
>> used since I joined the committer and I like it more then the other
>> format when the text starting on the same line at the function name.
>
> I ve reverted it. Sorry for that.
>
> Thank You.
No problem :) Just my OCD :)
Regards,
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: propchange - r32343 - svn:log
Posted by Senthil Kumaran S <se...@collab.net>.
Blair Zajac wrote:
> Would you mind reverting the formatting commit. That's the style I've
> used since I joined the committer and I like it more then the other
> format when the text starting on the same line at the function name.
I ve reverted it. Sorry for that.
Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org