[GitHub] [arrow] nealrichardson commented on a diff in pull request #12323: ARROW-9235: [R] Support for `connection` class when reading and writing files

[GitBox <gi...@apache.org>]

nealrichardson commented on code in PR #12323:
URL: https://github.com/apache/arrow/pull/12323#discussion_r847644873


##########
r/tests/testthat/test-feather.R:
##########
@@ -181,6 +181,17 @@ test_that("read_feather requires RandomAccessFile and errors nicely otherwise (A
   )
 })
 
+test_that("read_feather() and write_feather() accept connection objects", {
+  tf <- tempfile()
+  on.exit(unlink(tf))
+  write_feather(tibble::tibble(x = 1:5), file(tf))

Review Comment:
   Given that we do multithreaded handling of columns (right?) do we need to test with data that has more than one column, just to confirm that we aren't tripping over multiple threads calling the same connection concurrently?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org