You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by aaltay <gi...@git.apache.org> on 2016/07/18 22:40:39 UTC

[GitHub] incubator-beam pull request #685: Fixing broken example tests

GitHub user aaltay opened a pull request:

    https://github.com/apache/incubator-beam/pull/685

    Fixing broken example tests

    Nose does not pick up decorated tests unless the decorator name
    starts with test_. This resulted in some test being inadvertently
    disabled.
    
    Also OptionsContext
    (https://github.com/aaltay/incubator-beam/blob/python-sdk/sdks/python/apache_beam/utils/options.py#L457)
    is not doing what it is supposed to do. Its augment_options() method is
    not called therefore using OptionsContext does not override the option
    values as expected. I will remove this class and a few uses of it in
    tests, in a follow up.
    
    Finally removed contains_in_any_order in favor of equal_to. (As
    discuessed in:
    https://github.com/apache/incubator-beam/pull/650#discussion_r70906340

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aaltay/incubator-beam example2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/685.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #685
    
----
commit b54e15b3905a64e400c229da237ab3c9b3cafcfb
Author: Ahmet Altay <al...@google.com>
Date:   2016-07-18T21:24:51Z

    Fixing broken example tests
    
    Nose does not pick up decorated tests unless the decorator name
    starts with test_. This resulted in some test being inadvertently
    disabled.
    
    Also OptionsContext
    (https://github.com/aaltay/incubator-beam/blob/python-sdk/sdks/python/apache_beam/utils/options.py#L457)
    is not doing what it is supposed to do. Its augment_options() method is
    not called therefore using OptionsContext does not override the option
    values as expected. I will remove this class and a few uses of it in
    tests, in a follow up.
    
    Finally removed contains_in_any_order in favor of equal_to. (As
    discuessed in:
    https://github.com/apache/incubator-beam/pull/650#discussion_r70906340

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #685: Fixing broken example tests

Posted by aaltay <gi...@git.apache.org>.
Github user aaltay closed the pull request at:

    https://github.com/apache/incubator-beam/pull/685


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---