You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2016/06/09 05:45:20 UTC

[GitHub] flink pull request #1962: [FLINK-3857][Streaming Connectors]Add reconnect at...

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1962#discussion_r66385603
  
    --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java ---
    @@ -153,9 +165,90 @@ public ElasticsearchSink(Map<String, String> userConfig, List<InetSocketAddress>
     	 */
     	@Override
     	public void open(Configuration configuration) {
    +		connect();
    +
    +		params = ParameterTool.fromMap(userConfig);
    +
    +		if (params.has(CONFIG_KEY_CONNECTION_RETRIES)) {
    +			this.connectionRetries = params.getInt(CONFIG_KEY_CONNECTION_RETRIES);
    +		}
    --- End diff --
    
    Need to have a default value set if not specified by user? Otherwise null exception in invoke().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---