You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@falcon.apache.org by pa...@apache.org on 2018/04/17 08:48:25 UTC
falcon git commit: FALCON-2333 FilteredCopyListing#shouldCopy
override for new function signature
Repository: falcon
Updated Branches:
refs/heads/master 1a5b4f6a5 -> 272e999c1
FALCON-2333 FilteredCopyListing#shouldCopy override for new function signature
Build succeeds on local with checkstyle enabled
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Falcon ...................................... SUCCESS [ 29.596 s]
[INFO] Apache Falcon UI ................................... SUCCESS [ 30.419 s]
[INFO] Build Tools ........................................ SUCCESS [ 20.110 s]
[INFO] Apache Falcon Java common types .................... SUCCESS [ 54.352 s]
[INFO] Apache Falcon Metrics .............................. SUCCESS [ 21.369 s]
[INFO] Apache Falcon Hadoop Dependencies .................. SUCCESS [ 23.484 s]
[INFO] Apache Falcon Test Utility ......................... SUCCESS [ 19.320 s]
[INFO] Apache Falcon Commons .............................. SUCCESS [05:45 min]
[INFO] Apache Falcon extensions ........................... SUCCESS [01:19 min]
[INFO] Apache Falcon Java client .......................... SUCCESS [ 46.655 s]
[INFO] Apache Falcon Shell ................................ SUCCESS [ 28.133 s]
[INFO] Apache Falcon CLI client ........................... SUCCESS [ 30.136 s]
[INFO] Apache Falcon Titan 1.0 support .................... SUCCESS [ 14.624 s]
[INFO] Apache Falcon Oozie EL Extension ................... SUCCESS [ 24.562 s]
[INFO] Apache Falcon Embedded Hadoop - Test Cluster ....... SUCCESS [01:02 min]
[INFO] Apache Falcon Sharelib Hive - Test Cluster ......... SUCCESS [ 7.371 s]
[INFO] Apache Falcon Sharelib Pig - Test Cluster .......... SUCCESS [ 2.580 s]
[INFO] Apache Falcon Sharelib Hcatalog - Test Cluster ..... SUCCESS [ 2.128 s]
[INFO] Apache Falcon Sharelib Oozie - Test Cluster ........ SUCCESS [ 0.899 s]
[INFO] Apache Falcon Test Tools - Test Cluster ............ SUCCESS [ 0.789 s]
[INFO] Apache Falcon Messaging ............................ SUCCESS [01:03 min]
[INFO] Apache Falcon LIfecycle Module ..................... SUCCESS [ 38.893 s]
[INFO] Apache Falcon Oozie Adaptor ........................ SUCCESS [04:16 min]
[INFO] Apache Falcon Scheduler ............................ SUCCESS [02:24 min]
[INFO] Apache Falcon Acquisition .......................... SUCCESS [ 51.916 s]
[INFO] Apache Falcon Distcp Replication ................... SUCCESS [ 35.040 s]
[INFO] Apache Falcon Retention ............................ SUCCESS [ 32.609 s]
[INFO] Apache Falcon Archival ............................. SUCCESS [ 2.186 s]
[INFO] Apache Falcon Rerun ................................ SUCCESS [ 40.828 s]
[INFO] Apache Falcon Prism ................................ SUCCESS [08:04 min]
[INFO] Apache Falcon Unit ................................. SUCCESS [04:04 min]
[INFO] Apache Falcon Examples ............................. SUCCESS [ 35.224 s]
[INFO] Apache Falcon Web Application ...................... SUCCESS [26:32 min]
[INFO] Apache Falcon Documentation ........................ SUCCESS [ 23.240 s]
[INFO] Apache Falcon Distro ............................... SUCCESS [03:09 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Author: Raghavendra Singh <ra...@inmobi.com>
Reviewers: @pallavi-rao
Closes #407 from RaghavendraSingh/master and squashes the following commits:
febf03f88 [Raghavendra Singh] FilteredCopyListing: fix checkstyle issue
0595e7963 [Raghavendra Singh] FilteredCopyListing: shouldCopy override for new function signature
Project: http://git-wip-us.apache.org/repos/asf/falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/falcon/commit/272e999c
Tree: http://git-wip-us.apache.org/repos/asf/falcon/tree/272e999c
Diff: http://git-wip-us.apache.org/repos/asf/falcon/diff/272e999c
Branch: refs/heads/master
Commit: 272e999c1bd5f288470adeeb6ff7d6af96ca9101
Parents: 1a5b4f6
Author: Raghavendra Singh <ra...@inmobi.com>
Authored: Tue Apr 17 14:18:19 2018 +0530
Committer: pallavi-rao <pa...@inmobi.com>
Committed: Tue Apr 17 14:18:19 2018 +0530
----------------------------------------------------------------------
.../apache/falcon/replication/FilteredCopyListing.java | 10 ++++++++++
1 file changed, 10 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/falcon/blob/272e999c/replication/src/main/java/org/apache/falcon/replication/FilteredCopyListing.java
----------------------------------------------------------------------
diff --git a/replication/src/main/java/org/apache/falcon/replication/FilteredCopyListing.java b/replication/src/main/java/org/apache/falcon/replication/FilteredCopyListing.java
index 295de92..e3a2974 100644
--- a/replication/src/main/java/org/apache/falcon/replication/FilteredCopyListing.java
+++ b/replication/src/main/java/org/apache/falcon/replication/FilteredCopyListing.java
@@ -69,6 +69,16 @@ public class FilteredCopyListing extends SimpleCopyListing {
@Override
protected boolean shouldCopy(Path path, DistCpOptions options) {
+ return shouldCopy(path);
+ }
+
+ /**
+ * From hadoop 2.8.0 onwards, the function signature has been changed to not use DistCpOptions.
+ * hence added another function that works with the new implementation.
+ *
+ * Preserving previous implementation as well for backward compatibility.
+ */
+ protected boolean shouldCopy(Path path) {
if (path.getName().equals(availabilityFlag)) {
return false;
}