You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wookie.apache.org by sc...@apache.org on 2009/12/13 00:17:50 UTC
svn commit: r890003 -
/incubator/wookie/trunk/src/org/apache/wookie/controller/Controller.java
Author: scottbw
Date: Sat Dec 12 23:17:49 2009
New Revision: 890003
URL: http://svn.apache.org/viewvc?rev=890003&view=rev
Log:
Fix POST to only return a 201 when a resource is actually created; return 200 if successfully executes without creating a new resource (e.g. if update by POST is allowed)
Modified:
incubator/wookie/trunk/src/org/apache/wookie/controller/Controller.java
Modified: incubator/wookie/trunk/src/org/apache/wookie/controller/Controller.java
URL: http://svn.apache.org/viewvc/incubator/wookie/trunk/src/org/apache/wookie/controller/Controller.java?rev=890003&r1=890002&r2=890003&view=diff
==============================================================================
--- incubator/wookie/trunk/src/org/apache/wookie/controller/Controller.java (original)
+++ incubator/wookie/trunk/src/org/apache/wookie/controller/Controller.java Sat Dec 12 23:17:49 2009
@@ -95,8 +95,11 @@
throws ServletException, IOException {
String name = locateRESTname(request);
try {
- create(name, request);
- response.setStatus(HttpServletResponse.SC_CREATED);
+ if (create(name, request)){
+ response.setStatus(HttpServletResponse.SC_CREATED);
+ } else {
+ response.setStatus(HttpServletResponse.SC_OK);
+ }
} catch (ResourceDuplicationException e) {
response.sendError(HttpServletResponse.SC_CONFLICT);// already exists with same name - need error message for this
} catch (InvalidParametersException e){