You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2019/09/19 06:17:41 UTC
[kudu-CR] metrics: modify MergeFrom to a void function
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14262
Change subject: metrics: modify MergeFrom to a void function
......................................................................
metrics: modify MergeFrom to a void function
Change-Id: Ie00d7d7989b8956295dff7088d6f94c75e64554d
---
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
3 files changed, 25 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/14262/1
--
To view, visit http://gerrit.cloudera.org:8080/14262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie00d7d7989b8956295dff7088d6f94c75e64554d
Gerrit-Change-Number: 14262
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] metrics: modify MergeFrom to a void function
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14262 )
Change subject: metrics: modify MergeFrom to a void function
......................................................................
metrics: modify MergeFrom to a void function
Change-Id: Ie00d7d7989b8956295dff7088d6f94c75e64554d
Reviewed-on: http://gerrit.cloudera.org:8080/14262
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
3 files changed, 25 insertions(+), 31 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie00d7d7989b8956295dff7088d6f94c75e64554d
Gerrit-Change-Number: 14262
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] metrics: modify MergeFrom to a void function
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14262 )
Change subject: metrics: modify MergeFrom to a void function
......................................................................
Patch Set 1: Verified+1 Code-Review+2
Overriding Jenkins, failure was in a known flaky test.
--
To view, visit http://gerrit.cloudera.org:8080/14262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie00d7d7989b8956295dff7088d6f94c75e64554d
Gerrit-Change-Number: 14262
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Sep 2019 20:03:54 +0000
Gerrit-HasComments: No
[kudu-CR] metrics: modify MergeFrom to a void function
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14262 )
Change subject: metrics: modify MergeFrom to a void function
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ie00d7d7989b8956295dff7088d6f94c75e64554d
Gerrit-Change-Number: 14262
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>