You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/11/27 04:48:57 UTC
Re: Review Request 63200: Added ContainerMountInfo to avoid
pre_exec_commands for mounts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63200/
-----------------------------------------------------------
(Updated Nov. 27, 2017, 4:48 a.m.)
Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-7306
https://issues.apache.org/jira/browse/MESOS-7306
Repository: mesos
Description
-------
Added ContainerMountInfo protobuf in ContainerLaunchInfo. It is used
by isolators and MesosContainerizer to describe mounts. Previously,
the additional mounts for each container is specified using
'pre_exec_commands', which is not very flexible and slow (requires a
fork/exec for each mount).
Diffs (updated)
-----
include/mesos/slave/containerizer.proto 0f1e1da6848e49504f402df517a584ecb0c362d0
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp ed6556830c1d6a72df22c1780ac77fe7d6225f99
src/slave/containerizer/mesos/isolators/filesystem/linux.hpp c7fbda55e619052edfa5cd97114544d8fefc3ea5
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp faf94909f995f7486b5f9cb7532af58a90a9eed3
src/slave/containerizer/mesos/isolators/filesystem/shared.cpp ccd3da253160d3676d975f4fe7475b591193f644
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 4d6f640db9c04a944fb9772c8fa4458f07be6031
src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 42bc2e1245c9c957604e6625244a48a564ca5a8c
src/slave/containerizer/mesos/isolators/volume/host_path.cpp 949510aba6b1f30a64f5f9a0777a4f03e2701302
src/slave/containerizer/mesos/isolators/volume/image.cpp 35966aa9a8702e53fa95b3e045cba9327623b99a
src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp ee5ea3dee3be197e923be544aab96806f0adf1cf
src/slave/containerizer/mesos/launch.cpp b1584ff292ada5463917792908a13e00859fd1ae
Diff: https://reviews.apache.org/r/63200/diff/5/
Changes: https://reviews.apache.org/r/63200/diff/4-5/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 63200: Added ContainerMountInfo to avoid
pre_exec_commands for mounts.
Posted by Jie Yu <yu...@gmail.com>.
> On Nov. 28, 2017, 8:15 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
> > Lines 391-394 (original)
> > <https://reviews.apache.org/r/63200/diff/5/?file=1901337#file1901337line394>
> >
> > Should we just remove MesosContainerizerMount subcommand (mesos/mount.hpp | cpp)? Since we might not expect to use it anymore I am assuming.
> >
> > We can do it in the separate patch.
Yes. I'll do that in a separate patch.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63200/#review192057
-----------------------------------------------------------
On Nov. 27, 2017, 4:48 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63200/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2017, 4:48 a.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-7306
> https://issues.apache.org/jira/browse/MESOS-7306
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added ContainerMountInfo protobuf in ContainerLaunchInfo. It is used
> by isolators and MesosContainerizer to describe mounts. Previously,
> the additional mounts for each container is specified using
> 'pre_exec_commands', which is not very flexible and slow (requires a
> fork/exec for each mount).
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto 0f1e1da6848e49504f402df517a584ecb0c362d0
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp ed6556830c1d6a72df22c1780ac77fe7d6225f99
> src/slave/containerizer/mesos/isolators/filesystem/linux.hpp c7fbda55e619052edfa5cd97114544d8fefc3ea5
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp faf94909f995f7486b5f9cb7532af58a90a9eed3
> src/slave/containerizer/mesos/isolators/filesystem/shared.cpp ccd3da253160d3676d975f4fe7475b591193f644
> src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 4d6f640db9c04a944fb9772c8fa4458f07be6031
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 42bc2e1245c9c957604e6625244a48a564ca5a8c
> src/slave/containerizer/mesos/isolators/volume/host_path.cpp 949510aba6b1f30a64f5f9a0777a4f03e2701302
> src/slave/containerizer/mesos/isolators/volume/image.cpp 35966aa9a8702e53fa95b3e045cba9327623b99a
> src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp ee5ea3dee3be197e923be544aab96806f0adf1cf
> src/slave/containerizer/mesos/launch.cpp b1584ff292ada5463917792908a13e00859fd1ae
>
>
> Diff: https://reviews.apache.org/r/63200/diff/5/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63200: Added ContainerMountInfo to avoid
pre_exec_commands for mounts.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63200/#review192057
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Lines 391-394 (original)
<https://reviews.apache.org/r/63200/#comment270053>
Should we just remove MesosContainerizerMount subcommand (mesos/mount.hpp | cpp)? Since we might not expect to use it anymore I am assuming.
We can do it in the separate patch.
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
Lines 410-413 (patched)
<https://reviews.apache.org/r/63200/#comment270056>
Should we add comments for why doing remount here?
- Gilbert Song
On Nov. 26, 2017, 8:48 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63200/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2017, 8:48 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-7306
> https://issues.apache.org/jira/browse/MESOS-7306
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added ContainerMountInfo protobuf in ContainerLaunchInfo. It is used
> by isolators and MesosContainerizer to describe mounts. Previously,
> the additional mounts for each container is specified using
> 'pre_exec_commands', which is not very flexible and slow (requires a
> fork/exec for each mount).
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto 0f1e1da6848e49504f402df517a584ecb0c362d0
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp ed6556830c1d6a72df22c1780ac77fe7d6225f99
> src/slave/containerizer/mesos/isolators/filesystem/linux.hpp c7fbda55e619052edfa5cd97114544d8fefc3ea5
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp faf94909f995f7486b5f9cb7532af58a90a9eed3
> src/slave/containerizer/mesos/isolators/filesystem/shared.cpp ccd3da253160d3676d975f4fe7475b591193f644
> src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 4d6f640db9c04a944fb9772c8fa4458f07be6031
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 42bc2e1245c9c957604e6625244a48a564ca5a8c
> src/slave/containerizer/mesos/isolators/volume/host_path.cpp 949510aba6b1f30a64f5f9a0777a4f03e2701302
> src/slave/containerizer/mesos/isolators/volume/image.cpp 35966aa9a8702e53fa95b3e045cba9327623b99a
> src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp ee5ea3dee3be197e923be544aab96806f0adf1cf
> src/slave/containerizer/mesos/launch.cpp b1584ff292ada5463917792908a13e00859fd1ae
>
>
> Diff: https://reviews.apache.org/r/63200/diff/5/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>