You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/24 18:13:36 UTC

[GitHub] anirudh2290 commented on a change in pull request #12019: [MXNET-753] Fallback when using non-MKLDNN supported operators

anirudh2290 commented on a change in pull request #12019: [MXNET-753] Fallback when using non-MKLDNN supported operators
URL: https://github.com/apache/incubator-mxnet/pull/12019#discussion_r212712432
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
 ##########
 @@ -356,6 +356,18 @@ static inline void InvalidateOutputs(const std::vector<NDArray> &arrs,
   }
 }
 
+// TODO(alexzai): (MXNET-856) Remove helper function after subgraph feature added
+static inline std::vector<NDArray> CreateDefaultInputs(const std::vector<NDArray> &arrs) {
 
 Review comment:
   can we pass a pointer to a vector as an argument instead of returning a vector.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services