[superset] branch chore/edit-only-horizontal-filterbar created (now b4f27c7de8)

[di...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

diegopucci pushed a change to branch chore/edit-only-horizontal-filterbar
in repository https://gitbox.apache.org/repos/asf/superset.git


      at b4f27c7de8 Verify edit permission

This branch includes the following new commits:

     new b4f27c7de8 Verify edit permission

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[superset] 01/01: Verify edit permission

[di...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

diegopucci pushed a commit to branch chore/edit-only-horizontal-filterbar
in repository https://gitbox.apache.org/repos/asf/superset.git

commit b4f27c7de8fbef6b152bc6b9b24733fbad41806e
Author: geido <di...@gmail.com>
AuthorDate: Tue Nov 1 15:28:27 2022 +0200

    Verify edit permission
---
 .../dashboard/components/nativeFilters/FilterBar/Header/index.tsx    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
index a9ae82cc7c..1f5440d639 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
@@ -93,9 +93,8 @@ const Header: FC<HeaderProps> = ({ toggleFiltersBar }) => {
   const dashboardId = useSelector<RootState, number>(
     ({ dashboardInfo }) => dashboardInfo.id,
   );
-  const canSetHorizontalFilterBar = isFeatureEnabled(
-    FeatureFlag.HORIZONTAL_FILTER_BAR,
-  );
+  const canSetHorizontalFilterBar =
+    canEdit && isFeatureEnabled(FeatureFlag.HORIZONTAL_FILTER_BAR);
 
   return (
     <Wrapper>