You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <pm...@apache.org> on 2019/11/09 10:35:50 UTC
Version 5.2 (Broken poms)
Hello,
We have an issue with generated poms:
1/ Unspecified version in ApacheJMeter_core for jorphan:
https://repo1.maven.org/maven2/org/apache/jmeter/ApacheJMeter_core/5.2/ApacheJMeter_core-5.2.pom
We have this:
<dependency><groupId>org.apache.jmeter</groupId><artifactId>jorphan</artifactId><version>unspecified</version></dependency>
2/ The other poms are wrong.
Previously all modules inherited from ApacheJMeter_parent .
ApacheJMeter_parent pom has not been released and other modules do not
reference it anymore anyway nor do they mention mandatory dependencies.
So this is a big problem for maven dependent projects
Can it be fixed without releasing a 5.2.1 ?
I created https://bz.apache.org/bugzilla/show_bug.cgi?id=63910
Regards
Philippe
Re: Version 5.2 (Broken poms)
Posted by Philippe Mouawad <ph...@gmail.com>.
As you know it’s oss, and we have to chose to which project we dedicate
time.
So maybe they had no slot at that time, they includes me :)
And anyway the impact is not only for this project it’s for anybody using
maven with jmeter 5.2
Regards
On Saturday, November 9, 2019, Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> I reached out to jmeter-maven-plugin 3 month ago, and they did not seem to
> care: https://github.com/jmeter-maven-plugin/jmeter-maven-
> plugin/issues/339
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: Version 5.2 (Broken poms)
Posted by Vladimir Sitnikov <si...@gmail.com>.
Vladimir>The current error
Just to clarify: I believe
https://github.com/apache/jmeter/commit/ef06709a780bc776ecc3b5d839c424d39bb1aeae
fixes
the poms,
and the current jmeter/master is ok.
Vladimir
Re: Version 5.2 (Broken poms)
Posted by Vladimir Sitnikov <si...@gmail.com>.
Mark>Secondly we don’t use any local files, we pull binaries directly down
from maven central using aether
Mark>currently the plugin wouldn’t use them anyway
Here you go:
https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/pull/345
The current error is "An error occurred:
org/xmlpull/v1/XmlPullParserException" (see
https://travis-ci.org/jmeter-maven-plugin/jmeter-maven-plugin/jobs/609714883#L3135
),
and I believe it has the same root cause as
https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/issues/187
Vladimir
Re: Version 5.2 (Broken poms)
Posted by Mark Collin <ma...@lazeryattack.com>.
Hi Vladimir,
I do take exception to the assertion that this is our fault.
As noted in that ticket you raised, the build system should have no effect on us. It doesn’t matter if you build with Ant, Maven, or Gradle as long as you upload valid binaries and a correct POM to maven central.
Secondly we don’t use any local files, we pull binaries directly down from maven central using aether, so there is no point in us running a local build and seeing what POM files are generated, currently the plugin wouldn’t use them anyway. I’m sure it’s possible to change that but to be frank I don’t have time (all PR’s to add this functionality gratefully accepted). Personally I barely manage to keep up with bug reports that are already raised (in fact a lot of the time I don’t even manage that) and we really only have 2 active (and I’m using the word active loosely because I’m not nearly as active as I should be) contributors.
We are not the only consumers of the binaries that are uploaded to maven central and it’s really not our responsibility to make sure that you are uploading viable POM files and binaries, that should really be part of your build/test/release process.
> On 9 Nov 2019, at 11:04, Vladimir Sitnikov <si...@gmail.com> wrote:
>
> I reached out to jmeter-maven-plugin 3 month ago, and they did not seem to
> care: https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/issues/339
>
> Vladimir
Re: Version 5.2 (Broken poms)
Posted by Vladimir Sitnikov <si...@gmail.com>.
I reached out to jmeter-maven-plugin 3 month ago, and they did not seem to
care: https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/issues/339
Vladimir
Re: Version 5.2 (Broken poms)
Posted by Philippe Mouawad <pm...@apache.org>.
Hello,
Point 1/ is correct
Point 2/ is not. The approach is now to remove inheritance and favor
explicit dependency.
a) But is it correct to declare dependencies of modules with scope
runtime ?
b) It was not the case previously, they has compile scope.
Thanks
On Sat, Nov 9, 2019 at 11:35 AM Philippe Mouawad <pm...@apache.org>
wrote:
> Hello,
> We have an issue with generated poms:
>
> 1/ Unspecified version in ApacheJMeter_core for jorphan:
>
> https://repo1.maven.org/maven2/org/apache/jmeter/ApacheJMeter_core/5.2/ApacheJMeter_core-5.2.pom
>
> We have this:
>
> <dependency><groupId>org.apache.jmeter</groupId><artifactId>jorphan</artifactId><version>unspecified</version></dependency>
>
>
> 2/ The other poms are wrong.
> Previously all modules inherited from ApacheJMeter_parent .
> ApacheJMeter_parent pom has not been released and other modules do not
> reference it anymore anyway nor do they mention mandatory dependencies.
>
> So this is a big problem for maven dependent projects
> Can it be fixed without releasing a 5.2.1 ?
>
> I created https://bz.apache.org/bugzilla/show_bug.cgi?id=63910
> Regards
> Philippe
>