[GitHub] [druid] cryptoe commented on a diff in pull request #13970: Add timeout to TaskStartTimeoutFault.

["cryptoe (via GitHub)" <gi...@apache.org>]

cryptoe commented on code in PR #13970:
URL: https://github.com/apache/druid/pull/13970#discussion_r1147107169


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/TaskStartTimeoutFault.java:
##########
@@ -25,25 +25,34 @@
 import org.apache.druid.msq.util.MultiStageQueryContext;
 
 import java.util.Objects;
+import java.util.concurrent.TimeUnit;
 
 @JsonTypeName(TaskStartTimeoutFault.CODE)
 public class TaskStartTimeoutFault extends BaseMSQFault
 {
   static final String CODE = "TaskStartTimeout";
 
   private final int numTasks;
+  private final long timeout;

Review Comment:
   Nit: we might want to document the additional field  in the reference.md for this fault  . 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org