You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by je...@apache.org on 2025/04/02 19:53:58 UTC
(cassandra) branch trunk updated: CASSANDRA-20496 - Add CQLSSTableWriter tests for Vectors and Constraints
This is an automated email from the ASF dual-hosted git repository.
jeetkundoug pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new b01274d6f6 CASSANDRA-20496 - Add CQLSSTableWriter tests for Vectors and Constraints
b01274d6f6 is described below
commit b01274d6f674e4f56811d800b6d6aebc0f5ee66c
Author: Doug Rohrer <do...@therohrers.org>
AuthorDate: Wed Apr 2 15:34:19 2025 -0400
CASSANDRA-20496 - Add CQLSSTableWriter tests for Vectors and Constraints
New features in the storage engine need to be appropriately tested in the CQLSSTableWriter code
so they can be used in the Analytics library and others utilizing the writer library.
Add a test for support of Vector data types and constraints to ensure they work with the
CQLSSTableWriter and make any changes necessary if they don’t.
patch by Doug Rohrer; reviewed by Bernardo Botella, Stefan Miklosovic for CASSANDRA-20496
---
.../cassandra/io/sstable/CQLSSTableWriterTest.java | 82 ++++++++++++++++++++++
1 file changed, 82 insertions(+)
diff --git a/test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterTest.java b/test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterTest.java
index 45de365a6c..b7b67ba9bd 100644
--- a/test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterTest.java
+++ b/test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterTest.java
@@ -39,6 +39,9 @@ import java.util.stream.StreamSupport;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
+
+import org.apache.cassandra.cql3.constraints.ConstraintViolationException;
+
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
@@ -54,6 +57,7 @@ import org.apache.cassandra.cql3.functions.types.LocalDate;
import org.apache.cassandra.cql3.functions.types.TypeCodec;
import org.apache.cassandra.cql3.functions.types.UDTValue;
import org.apache.cassandra.cql3.functions.types.UserType;
+import org.apache.cassandra.db.marshal.FloatType;
import org.apache.cassandra.db.marshal.UTF8Type;
import org.apache.cassandra.dht.ByteOrderedPartitioner;
import org.apache.cassandra.dht.Murmur3Partitioner;
@@ -77,6 +81,7 @@ import org.apache.cassandra.utils.ByteBufferUtil;
import org.apache.cassandra.utils.FBUtilities;
import org.apache.cassandra.utils.JavaDriverUtils;
import org.apache.cassandra.utils.OutputHandler;
+import org.assertj.core.api.Assertions;
import static org.apache.cassandra.utils.Clock.Global.currentTimeMillis;
import static org.junit.Assert.assertEquals;
@@ -1578,6 +1583,83 @@ public abstract class CQLSSTableWriterTest
assertFalse(indexDescriptor.isPerColumnIndexBuildComplete(new IndexIdentifier(keyspace, table, "idx2")));
}
+ @Test
+ public void testWritingVectorData() throws Exception
+ {
+ final String schema = "CREATE TABLE " + qualifiedTable + " ("
+ + " k int,"
+ + " v1 VECTOR<FLOAT, 5>,"
+ + " PRIMARY KEY (k)"
+ + ")";
+
+ CQLSSTableWriter writer = CQLSSTableWriter.builder()
+ .inDirectory(dataDir)
+ .forTable(schema)
+ .using("INSERT INTO " + keyspace + "." + table + " (k, v1) " +
+ "VALUES (?, ?)").build();
+
+ for (int i = 0; i < 100; i++)
+ {
+ writer.addRow(i, List.of( (float)i, (float)i, (float)i, (float)i, (float)i));
+ }
+
+ writer.close();
+ loadSSTables(dataDir, keyspace, table);
+
+ if (verifyDataAfterLoading)
+ {
+ UntypedResultSet resultSet = QueryProcessor.executeInternal("SELECT * FROM " + keyspace + "." + table);
+
+ assertEquals(resultSet.size(), 100);
+ int cnt = 0;
+ for (UntypedResultSet.Row row : resultSet)
+ {
+ assertEquals(cnt, row.getInt("k"));
+ List<Float> vector = row.getVector("v1", FloatType.instance, 5);
+ Assertions.assertThat(vector).hasSize(5);
+ final float floatCount = (float)cnt;
+ Assertions.assertThat(vector).allMatch(val -> val == floatCount);
+ cnt++;
+ }
+ }
+ }
+
+ @Test
+ public void testConstraintViolation() throws Exception
+ {
+ final String schema = "CREATE TABLE " + qualifiedTable + " ("
+ + " k int,"
+ + " v1 int CHECK v1 < 5 ,"
+ + " PRIMARY KEY (k)"
+ + ")";
+
+ CQLSSTableWriter writer = CQLSSTableWriter.builder()
+ .inDirectory(dataDir)
+ .forTable(schema)
+ .using("INSERT INTO " + keyspace + "." + table + " (k, v1) " +
+ "VALUES (?, ?)").build();
+
+ writer.addRow(1, 4);
+
+ Assertions.assertThatThrownBy(() -> writer.addRow(2, 11))
+ .describedAs("Should throw when adding a row that violates constraints")
+ .isInstanceOf(ConstraintViolationException.class)
+ .hasMessageContaining("Column value does not satisfy value constraint for column 'v1'. It should be v1 < 5");
+
+ writer.close();
+ loadSSTables(dataDir, keyspace, table);
+
+ if (verifyDataAfterLoading)
+ {
+ UntypedResultSet resultSet = QueryProcessor.executeInternal("SELECT * FROM " + keyspace + "." + table);
+
+ assertEquals(resultSet.size(), 1);
+ UntypedResultSet.Row row = resultSet.one();
+ assertEquals(1, row.getInt("k"));
+ assertEquals(4, row.getInt("v1"));
+ }
+ }
+
protected static void loadSSTables(File dataDir, final String ks, final String tb) throws ExecutionException, InterruptedException
{
SSTableLoader loader = new SSTableLoader(dataDir, new SSTableLoader.Client()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org