[GitHub] [incubator-doris] Gabriel39 commented on a diff in pull request #9974: Modify of fe/fe-core/src/main/org/apache/doris/catalog some files

[GitBox <gi...@apache.org>]

Gabriel39 commented on code in PR #9974:
URL: https://github.com/apache/incubator-doris/pull/9974#discussion_r890117550


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BrokerMgr.java:
##########
@@ -368,8 +368,8 @@ public ModifyBrokerInfo() {
         }
 
         public ModifyBrokerInfo(String brokerName, List<FsBroker> brokerAddresses) {
-            this.brokerName = brokerName;

Review Comment:
   Hi @whyy7777 , thanks for your contribution. Besides, I'm just wondering if this programming convention is better than before. Could you give some motivations for this PR? Maybe a programming convention adopted somewhere?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org