You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Norman Maurer (Created) (JIRA)" <ji...@apache.org> on 2012/01/18 18:56:41 UTC
[jira] [Created] (NET-438) POP3Client.capa() should call
POP3Client.getAdditionalReply()
POP3Client.capa() should call POP3Client.getAdditionalReply()
-------------------------------------------------------------
Key: NET-438
URL: https://issues.apache.org/jira/browse/NET-438
Project: Commons Net
Issue Type: Bug
Components: POP3
Affects Versions: 3.0.1
Reporter: Norman Maurer
As CAPA response contains multiple lines as response its neede to call getAdditionalReply() to consume all lines. Beside this it would make sense to move capa() from ExtendedPOP3Client to POP3Client. If you want to keep it in ExtendedPOP3Client it really would make sense to add all constructors of POP3SClient to allow also the usage with STARTTLS and POP3S
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-438) POP3Client.capa() should call
POP3Client.getAdditionalReply()
Posted by "Sebb (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196903#comment-13196903 ]
Sebb commented on NET-438:
--------------------------
Thanks, patch applied.
Luckily moving a method into a super-class does not break binary compatibility (according to Clirr)
I've deployed an updated snapshot in case you want to test it.
> POP3Client.capa() should call POP3Client.getAdditionalReply()
> -------------------------------------------------------------
>
> Key: NET-438
> URL: https://issues.apache.org/jira/browse/NET-438
> Project: Commons Net
> Issue Type: Bug
> Components: POP3
> Affects Versions: 3.0.1
> Reporter: Norman Maurer
> Fix For: 3.1
>
> Attachments: NET-438.diff
>
>
> As CAPA response contains multiple lines as response its neede to call getAdditionalReply() to consume all lines. Beside this it would make sense to move capa() from ExtendedPOP3Client to POP3Client. If you want to keep it in ExtendedPOP3Client it really would make sense to add all constructors of POP3SClient to allow also the usage with STARTTLS and POP3S
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-438) POP3Client.capa() should call
POP3Client.getAdditionalReply()
Posted by "Norman Maurer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer updated NET-438:
------------------------------
Attachment: NET-438.diff
> POP3Client.capa() should call POP3Client.getAdditionalReply()
> -------------------------------------------------------------
>
> Key: NET-438
> URL: https://issues.apache.org/jira/browse/NET-438
> Project: Commons Net
> Issue Type: Bug
> Components: POP3
> Affects Versions: 3.0.1
> Reporter: Norman Maurer
> Attachments: NET-438.diff
>
>
> As CAPA response contains multiple lines as response its neede to call getAdditionalReply() to consume all lines. Beside this it would make sense to move capa() from ExtendedPOP3Client to POP3Client. If you want to keep it in ExtendedPOP3Client it really would make sense to add all constructors of POP3SClient to allow also the usage with STARTTLS and POP3S
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (NET-438) POP3Client.capa() should call
POP3Client.getAdditionalReply()
Posted by "Sebb (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-438.
----------------------
Resolution: Fixed
Fix Version/s: 3.1
> POP3Client.capa() should call POP3Client.getAdditionalReply()
> -------------------------------------------------------------
>
> Key: NET-438
> URL: https://issues.apache.org/jira/browse/NET-438
> Project: Commons Net
> Issue Type: Bug
> Components: POP3
> Affects Versions: 3.0.1
> Reporter: Norman Maurer
> Fix For: 3.1
>
> Attachments: NET-438.diff
>
>
> As CAPA response contains multiple lines as response its neede to call getAdditionalReply() to consume all lines. Beside this it would make sense to move capa() from ExtendedPOP3Client to POP3Client. If you want to keep it in ExtendedPOP3Client it really would make sense to add all constructors of POP3SClient to allow also the usage with STARTTLS and POP3S
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-438) POP3Client.capa() should call
POP3Client.getAdditionalReply()
Posted by "Norman Maurer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188569#comment-13188569 ]
Norman Maurer commented on NET-438:
-----------------------------------
Hiere is the patch for it..
> POP3Client.capa() should call POP3Client.getAdditionalReply()
> -------------------------------------------------------------
>
> Key: NET-438
> URL: https://issues.apache.org/jira/browse/NET-438
> Project: Commons Net
> Issue Type: Bug
> Components: POP3
> Affects Versions: 3.0.1
> Reporter: Norman Maurer
> Attachments: NET-438.diff
>
>
> As CAPA response contains multiple lines as response its neede to call getAdditionalReply() to consume all lines. Beside this it would make sense to move capa() from ExtendedPOP3Client to POP3Client. If you want to keep it in ExtendedPOP3Client it really would make sense to add all constructors of POP3SClient to allow also the usage with STARTTLS and POP3S
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira